r79344 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79343‎ | r79344 | r79345 >
Date:16:13, 31 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Missing param from getPossibleErrors are done automagically, so no benefit from doing it explicitally in the implementations
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiCodeDiff.php (modified) (history)
  • /trunk/extensions/CodeReview/api/ApiCodeUpdate.php (modified) (history)
  • /trunk/extensions/CodeReview/api/ApiQueryCodeComments.php (modified) (history)
  • /trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php (modified) (history)
  • /trunk/extensions/CodeReview/api/ApiRevisionUpdate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiRevisionUpdate.php
@@ -142,8 +142,6 @@
143143 array( 'code' => 'permissiondenied', 'info' => 'You don\'t have permission to update code' ),
144144 array( 'code' => 'invalidrepo', 'info' => "Invalid repo ``repo''" ),
145145 array( 'code' => 'nosuchrev', 'info' => 'There is no revision with ID \'rev\'' ),
146 - array( 'missingparam', 'repo' ),
147 - array( 'missingparam', 'rev' ),
148146 ) );
149147 }
150148
Index: trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php
@@ -176,7 +176,6 @@
177177
178178 public function getPossibleErrors() {
179179 return array_merge( parent::getPossibleErrors(), array(
180 - array( 'missingparam', 'repo' ),
181180 array( 'code' => 'permissiondenied', 'info' => 'You don\'t have permission to view code revisions' ),
182181 array( 'code' => 'invalidrepo', 'info' => "Invalid repo ``repo''" ),
183182 ) );
Index: trunk/extensions/CodeReview/api/ApiCodeDiff.php
@@ -88,8 +88,6 @@
8989 array( 'code' => 'permissiondenied', 'info' => 'You don\'t have permission to view code diffs' ),
9090 array( 'code' => 'invalidrepo', 'info' => "Invalid repo ``repo''" ),
9191 array( 'code' => 'nosuchrev', 'info' => 'There is no revision with ID \'rev\'' ),
92 - array( 'missingparam', 'repo' ),
93 - array( 'missingparam', 'rev' ),
9492 ) );
9593 }
9694
Index: trunk/extensions/CodeReview/api/ApiQueryCodeComments.php
@@ -146,7 +146,6 @@
147147
148148 public function getPossibleErrors() {
149149 return array_merge( parent::getPossibleErrors(), array(
150 - array( 'missingparam', 'repo' ),
151150 array( 'code' => 'permissiondenied', 'info' => 'You don\'t have permission to view code comments' ),
152151 array( 'code' => 'invalidrepo', 'info' => "Invalid repo ``repo''" ),
153152 ) );
Index: trunk/extensions/CodeReview/api/ApiCodeUpdate.php
@@ -113,8 +113,6 @@
114114 return array_merge( parent::getPossibleErrors(), array(
115115 array( 'code' => 'permissiondenied', 'info' => 'You don\'t have permission to update code' ),
116116 array( 'code' => 'invalidrepo', 'info' => "Invalid repo ``repo''" ),
117 - array( 'missingparam', 'repo' ),
118 - array( 'missingparam', 'rev' ),
119117 ) );
120118 }
121119

Status & tagging log