r79293 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79292‎ | r79293 | r79294 >
Date:21:07, 30 December 2010
Author:reedy
Status:deferred
Tags:
Comment:
Properly qualify UPLOAD_SESSION
Modified paths:
  • /trunk/extensions/FirefoggChunkedUpload/FirefoggChunkedUploadHandler.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FirefoggChunkedUpload/FirefoggChunkedUploadHandler.php
@@ -38,19 +38,19 @@
3939 foreach ( array( 'mFilteredName', 'repoPath', 'mFileSize', 'mDesiredDestName' )
4040 as $key ) {
4141 if ( isset( $this->$key ) ) {
42 - $_SESSION[self::SESSION_KEYNAME][$this->sessionKey][$key] = $this->$key;
 42+ $_SESSION[UploadBase::SESSION_KEYNAME][$this->sessionKey][$key] = $this->$key;
4343 }
4444 }
4545 if ( isset( $comment ) ) {
46 - $_SESSION[self::SESSION_KEYNAME][$this->sessionKey]['commment'] = $comment;
 46+ $_SESSION[UploadBase::SESSION_KEYNAME][$this->sessionKey]['commment'] = $comment;
4747 }
4848 if ( isset( $pageText ) ) {
49 - $_SESSION[self::SESSION_KEYNAME][$this->sessionKey]['pageText'] = $pageText;
 49+ $_SESSION[UploadBase::SESSION_KEYNAME][$this->sessionKey]['pageText'] = $pageText;
5050 }
5151 if ( isset( $watchlist ) ) {
52 - $_SESSION[self::SESSION_KEYNAME][$this->sessionKey]['watchlist'] = $watchlist;
 52+ $_SESSION[UploadBase::SESSION_KEYNAME][$this->sessionKey]['watchlist'] = $watchlist;
5353 }
54 - $_SESSION[self::SESSION_KEYNAME][$this->sessionKey]['version'] = self::SESSION_VERSION;
 54+ $_SESSION[UploadBase::SESSION_KEYNAME][$this->sessionKey]['version'] = UploadBase::SESSION_VERSION;
5555
5656 return $this->sessionKey;
5757 }
@@ -108,7 +108,7 @@
109109 $this->sessionKey = $sessionKey;
110110
111111 if ( isset( $sessionData[$this->sessionKey]['version'] )
112 - && $sessionData[$this->sessionKey]['version'] == self::SESSION_VERSION )
 112+ && $sessionData[$this->sessionKey]['version'] == UploadBase::SESSION_VERSION )
113113 {
114114 foreach ( array( 'comment', 'pageText', 'watchlist', 'mFilteredName', 'repoPath', 'mFileSize', 'mDesiredDestName' )
115115 as $key ) {
@@ -138,7 +138,7 @@
139139
140140 if ( $this->status->isOK() ) {
141141 $this->repoPath = $this->status->value;
142 - $_SESSION[self::SESSION_KEYNAME][$this->sessionKey]['repoPath'] = $this->repoPath;
 142+ $_SESSION[UploadBase::SESSION_KEYNAME][$this->sessionKey]['repoPath'] = $this->repoPath;
143143 }
144144 return $this->status;
145145 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r88241fixed r88236 commit, renamed FirefoggChunkedUpload r79293 to ResumableUpload,...dale15:09, 16 May 2011

Status & tagging log