r79275 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79274‎ | r79275 | r79276 >
Date:17:41, 30 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Fix private class member variable access

Some method documentation
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -808,7 +808,7 @@
809809 # Returns the size of a text field, or -1 for "unlimited"
810810 function textFieldSize( $table, $field ) {
811811 $fieldInfoData = $this->fieldInfo( $table, $field);
812 - if ( $fieldInfoData->type == 'varchar' ) {
 812+ if ( $fieldInfoData->type() == 'varchar' ) {
813813 $size = $row->size - 4;
814814 } else {
815815 $size = $row->size;
@@ -928,6 +928,7 @@
929929 *
930930 * @param $table Array
931931 * @param $field String
 932+ * @return ORAField
932933 */
933934 private function fieldInfoMulti( $table, $field ) {
934935 $field = strtoupper( $field );
@@ -975,6 +976,12 @@
976977 return $fieldInfoTemp;
977978 }
978979
 980+ /**
 981+ * @throws DBUnexpectedError
 982+ * @param $table
 983+ * @param $field
 984+ * @return ORAField
 985+ */
979986 function fieldInfo( $table, $field ) {
980987 if ( is_array( $table ) ) {
981988 throw new DBUnexpectedError( $this, 'DatabaseOracle::fieldInfo called with table array!' );

Status & tagging log