r79243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79242‎ | r79243 | r79244 >
Date:10:03, 30 December 2010
Author:dantman
Status:ok
Tags:
Comment:
Followup r79055 c12495 fix undefined index notice.
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -1307,7 +1307,9 @@
13081308 $personal_tools[$key] = array();
13091309 $personal_tools[$key]["links"][] = array();
13101310 $personal_tools[$key]["links"][0]["single-id"] = $personal_tools[$key]["id"] = "pt-$key";
1311 - $personal_tools[$key]["active"] = $ptool["active"];
 1311+ if ( isset($ptool["active"]) ) {
 1312+ $personal_tools[$key]["active"] = $ptool["active"];
 1313+ }
13121314 foreach ( array("href", "class", "text") as $k ) {
13131315 if ( isset($ptool[$k]) )
13141316 $personal_tools[$key]["links"][0][$k] = $ptool[$k];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79055Commit getPersonalTools to allow personal bar generation to be simplified.dantman12:23, 27 December 2010

Status & tagging log