r79228 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79227‎ | r79228 | r79229 >
Date:02:41, 30 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Array to array

Add some function documentation
Modified paths:
  • /trunk/phase3/includes/db/CloneDatabase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/CloneDatabase.php
@@ -63,7 +63,7 @@
6464 * @param $newTablePrefix String Prefix to assign to the tables
6565 * @param $oldTablePrefix String Prefix on current tables, if not $wgDBprefix
6666 */
67 - public function __construct( DatabaseBase $db, Array $tablesToClone,
 67+ public function __construct( DatabaseBase $db, array $tablesToClone,
6868 $newTablePrefix = 'parsertest', $oldTablePrefix = '', $dropCurrentTables = true )
6969 {
7070 $this->db = $db;
@@ -119,6 +119,9 @@
120120
121121 /**
122122 * Change the table prefix on all open DB connections/
 123+ *
 124+ * @param $prefix
 125+ * @return void
123126 */
124127 protected function changePrefix( $prefix ) {
125128 global $wgDBprefix;
@@ -126,10 +129,20 @@
127130 $wgDBprefix = $prefix;
128131 }
129132
 133+ /**
 134+ * @param $lb
 135+ * @param $prefix
 136+ * @return void
 137+ */
130138 public function changeLBPrefix( $lb, $prefix ) {
131139 $lb->forEachOpenConnection( array( $this, 'changeDBPrefix' ), array( $prefix ) );
132140 }
133141
 142+ /**
 143+ * @param $db DatabaseBase
 144+ * @param $prefix
 145+ * @return void
 146+ */
134147 public function changeDBPrefix( $db, $prefix ) {
135148 $db->tablePrefix( $prefix );
136149 }

Status & tagging log