r79181 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79180‎ | r79181 | r79182 >
Date:16:15, 29 December 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r67663. Now with 100% less sugar, er.. @s!
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.php
@@ -867,12 +867,14 @@
868868 }
869869
870870 if ( $this->followRedirects && $this->canFollowRedirects() ) {
871 - if ( ! @curl_setopt( $curlHandle, CURLOPT_FOLLOWLOCATION, true ) ) {
 871+ wfSuppressWarnings();
 872+ if ( ! curl_setopt( $curlHandle, CURLOPT_FOLLOWLOCATION, true ) ) {
872873 wfDebug( __METHOD__ . ": Couldn't set CURLOPT_FOLLOWLOCATION. " .
873874 "Probably safe_mode or open_basedir is set.\n" );
874875 // Continue the processing. If it were in curl_setopt_array,
875876 // processing would have halted on its entry
876877 }
 878+ wfRestoreWarnings();
877879 }
878880
879881 if ( false === curl_exec( $curlHandle ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67663Enable http compression....platonides20:01, 8 June 2010

Status & tagging log