r79156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79155‎ | r79156 | r79157 >
Date:02:49, 29 December 2010
Author:dale
Status:deferred
Tags:
Comment:
fixed bug 25495 increased share text area height
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js (modified) (history)
  • /branches/MwEmbedStandAlone/tests/selenium_tests/EmbedPlayerLoadsTest.php (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/tests/selenium_tests/EmbedPlayerLoadsTest.php
@@ -8,7 +8,7 @@
99 // create test suite
1010 $wgSeleniumTestSuites['EmbedPlayerLoadingTests'] = new SeleniumTestSuite('Embed Player Loading Test Suite');
1111 $wgSeleniumTestSuites['EmbedPlayerLoadingTests']->addTest(new EmbedPlayerLoads());
12 -
 12+
1313 class EmbedPlayerLoads extends SeleniumTestCase
1414 {
1515 public $name = "Embed Player Loading Test";
Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js
@@ -1253,7 +1253,7 @@
12541254 $shareInterface.append(
12551255
12561256 $j( '<textarea />' )
1257 - .attr( 'rows', 1 )
 1257+ .attr( 'rows', 4 )
12581258 .html( embed_code )
12591259 .click( function() {
12601260 $j( this ).select();

Status & tagging log