r79095 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79094‎ | r79095 | r79096 >
Date:01:22, 28 December 2010
Author:demon
Status:ok
Tags:
Comment:
Nitpick r79094: fix var names
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -2642,15 +2642,15 @@
26432643 /**
26442644 * Delete a table
26452645 */
2646 - public function dropTable( $tableName, $method = 'DatabaseBase::dropTable' ) {
2647 - if( !$this->tableExists( $tableName, $method ) ) {
 2646+ public function dropTable( $tableName, $fName = 'DatabaseBase::dropTable' ) {
 2647+ if( !$this->tableExists( $tableName ) ) {
26482648 return false;
26492649 }
26502650 $sql = "DROP TABLE " . $this->tableName( $tableName );
26512651 if( $this->cascadingDeletes() ) {
26522652 $sql .= " CASCADE";
26532653 }
2654 - return $this->query( $sql );
 2654+ return $this->query( $sql, $fName );
26552655 }
26562656
26572657 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79094Followup r79093: Move DROP TABLE code to Database classes and properly rename...demon01:19, 28 December 2010

Status & tagging log