r79033 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79032‎ | r79033 | r79034 >
Date:22:50, 26 December 2010
Author:yaron
Status:deferred
Tags:
Comment:
Replaced calls to functions in SFLinkUtils that have been moved to SFUtils class
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormClasses.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormEditPage.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateCategory.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_CreateCategory.php
@@ -97,7 +97,7 @@
9898 }
9999
100100 $subcategory_label = wfMsg( 'sf_createcategory_makesubcategory' );
101 - $categories = SFLinkUtils::getCategoriesForArticle();
 101+ $categories = SFUtils::getCategoriesForPage();
102102 $sk = $wgUser->getSkin();
103103 $cf = SpecialPage::getPage( 'CreateForm' );
104104 $create_form_link = $sk->makeKnownLinkObj( $cf->getTitle(), $cf->getDescription() );
Index: trunk/extensions/SemanticForms/includes/SF_FormClasses.php
@@ -28,7 +28,7 @@
2929 function createMarkup() {
3030 $title = Title::makeTitle( SF_NS_FORM, $this->form_name );
3131 $fs = SpecialPage::getPage( 'FormStart' );
32 - $form_start_url = SFLinkUtils::titleURLString( $fs->getTitle() ) . "/" . $title->getPartialURL();
 32+ $form_start_url = SFUtils::titleURLString( $fs->getTitle() ) . "/" . $title->getPartialURL();
3333 $form_description = wfMsgForContent( 'sf_form_docu', $this->form_name, $form_start_url );
3434 $form_input = "{{#forminput:form=" . $this->form_name . "}}\n";
3535 $text = <<<END
Index: trunk/extensions/SemanticForms/includes/SF_FormEditPage.php
@@ -45,7 +45,7 @@
4646 protected function showContentForm() {
4747 global $sfgIP;
4848 $target_title = $this->mArticle->getTitle();
49 - $target_name = SFLinkUtils::titleString( $target_title );
 49+ $target_name = SFUtils::titleString( $target_title );
5050 if ( $target_title->exists() ) {
5151 SFEditData::printEditForm( $this->form_name, $target_name, $this->textbox1 );
5252 } else {

Status & tagging log