r78986 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78985‎ | r78986 | r78987 >
Date:23:25, 24 December 2010
Author:krinkle
Status:deferred
Tags:
Comment:
Last bits of mw-js conventions
Modified paths:
  • /trunk/extensions/Translate/js/quickedit.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/js/quickedit.js
@@ -48,7 +48,9 @@
4949
5050 function addAccessKeys(dialog) {
5151 jQuery( '[accesskey=a], [accesskey=s], [accesskey=d], [accesskey=h]' ).each(
52 - function(i) { jQuery(this).removeAttr( 'accesskey' ); }
 52+ function( i ) {
 53+ jQuery(this).removeAttr( 'accesskey' );
 54+ }
5355 );
5456 dialog.find( '.mw-translate-save' ).attr( 'accesskey', 'a' ).attr( 'title', '[' + tooltipAccessKeyPrefix + 'a]' );
5557 dialog.find( '.mw-translate-next' ).attr( 'accesskey', 's' ).attr( 'title', '[' + tooltipAccessKeyPrefix + 's]' );
@@ -106,12 +108,14 @@
107109 var checker = new MessageCheckUpdater( function() {
108110 var url = wgScript + '?title=Special:Translate/editpage&suggestions=checks&page=$1&loadgroup=$2';
109111 url = url.replace( '$1', encodeURIComponent( page ) ).replace( '$2', encodeURIComponent( group ) );
110 - jQuery.post( url, { translation: textarea.val() } , function( mydata ) {
 112+ jQuery.post( url, { translation: textarea.val() }, function( mydata ) {
111113 form.find( '.mw-translate-messagechecks' ).replaceWith( mydata );
112114 } );
113115 } );
114116
115 - textarea.keyup( function() { checker.setup(); } );
 117+ textarea.keyup( function() {
 118+ checker.setup();
 119+ } );
116120 }
117121
118122 addAccessKeys( form );

Status & tagging log