r78954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78953‎ | r78954 | r78955 >
Date:12:08, 24 December 2010
Author:platonides
Status:ok
Tags:
Comment:
Add a couple of comments from my WC
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/GlobalTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/GlobalTest.php
@@ -43,13 +43,13 @@
4444 $f = fopen( $wgReadOnlyFile, "wt" );
4545 fwrite( $f, 'Message' );
4646 fclose( $f );
47 - $wgReadOnly = null;
 47+ $wgReadOnly = null; # Check on $wgReadOnlyFile
4848
4949 $this->assertTrue( wfReadOnly() );
50 - $this->assertTrue( wfReadOnly() );
 50+ $this->assertTrue( wfReadOnly() ); # Check cached
5151
5252 unlink( $wgReadOnlyFile );
53 - $wgReadOnly = null;
 53+ $wgReadOnly = null; # Clean cache
5454
5555 $this->assertFalse( wfReadOnly() );
5656 $this->assertFalse( wfReadOnly() );

Status & tagging log