r78912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78911‎ | r78912 | r78913 >
Date:19:13, 23 December 2010
Author:dale
Status:deferred
Tags:
Comment:
fixed bug 25879 ( event was bubbling up and canceling itself )
Modified paths:
  • /branches/MwEmbedStandAlone/modules/ClipEdit/mw.ClipEdit.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/ClipEdit/mw.ClipEdit.js
@@ -458,7 +458,7 @@
459459 var _this = this;
460460 var eb = $j( '#embed_vid' ).get( 0 );
461461 // turn on preview to avoid onDone actions
462 - eb.preview_mode = true;
 462+ eb.previewMode = true;
463463 $j( '#' + this.target_control_display ).html( '<h3>' + gM( 'mwe-clipedit-edit-video-tools' ) + '</h3>' );
464464 if ( eb.supportsURLTimeEncoding() ) {
465465 if ( eb.end_ntp ) {
@@ -739,19 +739,19 @@
740740 $j( '#mw_layout_' + _this.resource.layout )[0].checked = true;
741741
742742 // Left radio click
743 - $j( '#mw_layout_left,#mw_layout_left_img' ).click( function() {
 743+ $j( '#mw_layout_left,#mw_layout_left_img' ).click( function( event ) {
744744 $j( '#mw_layout_right' )[0].checked = false;
745745 $j( '#mw_layout_left' )[0].checked = true;
746746 _this.resource.layout = 'left';
747 - return true;
 747+ event.stopPropagation();
748748 } );
749749
750750 // Right radio click
751 - $j( '#mw_layout_right,#mw_layout_right_img' ).click( function() {
 751+ $j( '#mw_layout_right,#mw_layout_right_img' ).click( function( event ) {
752752 $j( '#mw_layout_left' )[0].checked = false;
753753 $j( '#mw_layout_right' )[0].checked = true;
754754 _this.resource.layout = 'right';
755 - return true;
 755+ event.stopPropagation();
756756 } );
757757 break;
758758 case 'crop':

Status & tagging log