r78910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78909‎ | r78910 | r78911 >
Date:18:54, 23 December 2010
Author:laner
Status:deferred
Tags:
Comment:
Removing getHosts function, since it is implemented in OpenStackNovaHosts
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaDomain.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaDomain.php
@@ -41,20 +41,6 @@
4242 return $this->fqdn;
4343 }
4444
45 - function getHosts() {
46 - global $wgAuth;
47 -
48 - # Domains can have records as sub entries. If sub-entries exist, fail.
49 - $result = ldap_list( $wgAuth->ldapconn, $this->domainDN, 'objectclass=*' );
50 - $hostsLDAP = ldap_get_entries( $wgAuth->ldapconn, $result );
51 - array_shift( $hostsLDAP );
52 - foreach ( $hostsLDAP as $hostLDAP ) {
53 - $hosts[] = new OpenStackNovaHost( $hostLDAP[0]['dc'] ); // FIXME: Missing constructor parameter
54 - }
55 -
56 - return $hosts;
57 - }
58 -
5945 function updateSOA() {
6046 global $wgAuth;
6147

Status & tagging log