r78907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78906‎ | r78907 | r78908 >
Date:18:35, 23 December 2010
Author:reedy
Status:deferred
Tags:
Comment:
Define variables passed as reference before usage
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaUser.php
@@ -196,8 +196,10 @@
197197 }
198198
199199 static function uuid4() {
 200+ $uuid = '';
200201 uuid_create( &$uuid );
201202 uuid_make( $uuid, UUID_MAKE_V4 );
 203+ $uuidExport = '';
202204 uuid_export( $uuid, UUID_FMT_STR, &$uuidExport );
203205 return trim( $uuidExport );
204206 }

Status & tagging log