r78859 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78858‎ | r78859 | r78860 >
Date:23:03, 22 December 2010
Author:yaron
Status:deferred
Tags:
Comment:
Minor improvements to the comments.
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormField.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormField.php
@@ -170,7 +170,7 @@
171171 $text .= '<p>' . wfMsg( 'sf_createform_fieldprop', $prop_link_text,
172172 SFUtils::linkText( SMW_NS_TYPE, $template_field->field_type ) ) . "</p>\n";
173173 }
174 - // if it's not a semantic field - don't add any text
 174+ // If it's not a semantic field - don't add any text.
175175 $form_label_text = wfMsg( 'sf_createform_formlabel' );
176176 $field_label = $template_field->label;
177177 $input_type_text = wfMsg( 'sf_createform_inputtype' );
@@ -257,10 +257,10 @@
258258 $other_args['is_list'] = ( $this->is_list || $this->template_field->is_list );
259259 if ( $this->template_field->semantic_property != '' && ! array_key_exists( 'semantic_property', $other_args ) )
260260 $other_args['semantic_property'] = $this->template_field->semantic_property;
261 - // if autocompletion hasn't already been hardcoded in the form,
 261+ // If autocompletion hasn't already been hardcoded in the form,
262262 // and it's a property of type page, or a property of another
263263 // type with 'autocomplete' specified, set the necessary
264 - // parameters
 264+ // parameters.
265265 if ( ! array_key_exists( 'autocompletion source', $other_args ) ) {
266266 if ( $this->template_field->propertyIsOfType( '_wpg' ) ) {
267267 $other_args['autocompletion source'] = $this->template_field->semantic_property;
@@ -270,9 +270,9 @@
271271 $other_args['autocomplete field type'] = 'attribute';
272272 }
273273 }
274 - // now merge in the default values set by SFFormPrinter, if
 274+ // Now merge in the default values set by SFFormPrinter, if
275275 // there were any - put the default values first, so that if
276 - // there's a conflict they'll be overridden
 276+ // there's a conflict they'll be overridden.
277277 if ( $default_args != null )
278278 $other_args = array_merge( $default_args, $other_args );
279279 return $other_args;

Status & tagging log