r78815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78814‎ | r78815 | r78816 >
Date:18:17, 22 December 2010
Author:catrope
Status:deferred
Tags:
Comment:
Followup r78810, change constructor call to something I think won't break. Still gotta actually test this on a pre-QPW2 install though
Modified paths:
  • /trunk/extensions/ApprovedRevs/SpecialApprovedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ApprovedRevs/SpecialApprovedRevs.php
@@ -38,7 +38,9 @@
3939 private $mMode;
4040
4141 public function __construct( $mode ) {
42 - parent::__construct( 'ApprovedRevs' );
 42+ if ( $this instanceof SpecialPage ) {
 43+ parent::__construct( 'ApprovedRevs' );
 44+ }
4345 $this->mMode = $mode;
4446 }
4547

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78810Fix ApprovedRevs to be dual-compatible with the QueryPage rewrite in 1.18 and...catrope17:44, 22 December 2010

Status & tagging log