r78799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78798‎ | r78799 | r78800 >
Date:15:47, 22 December 2010
Author:catrope
Status:deferred
Tags:
Comment:
1.16wmf4: MFT r78787
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/ContributionReporting/ContributionReporting.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/ContributionReporting/ContributionReporting.php
@@ -96,8 +96,11 @@
9797 $egFundraiserStatisticsMinimum = 1;
9898 $egFundraiserStatisticsMaximum = 10000;
9999
 100+// Cache timeout for fundraiser statistics, in seconds
 101+$egFundraiserStatisticsCacheTimeout = 300; // 5 minutes
100102
101103
 104+
102105 $wgContributionTrackingStatisticsViewWeeks = 3;
103106
104107 $wgHooks['ParserFirstCallInit'][] = 'efContributionReportingSetup';
Index: branches/wmf/1.16wmf4/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -218,7 +218,7 @@
219219 /* Private Functions */
220220
221221 private function query( $type, $start, $end ) {
222 - global $wgMemc, $egFundraiserStatisticsMinimum, $egFundraiserStatisticsMaximum;
 222+ global $wgMemc, $egFundraiserStatisticsMinimum, $egFundraiserStatisticsMaximum, $egFundraiserStatisticsCacheTimeout;
223223
224224 $key = wfMemcKey( 'fundraiserstatistics', $type, $start, $end );
225225 $cache = $wgMemc->get( $key );
@@ -310,8 +310,7 @@
311311 break;
312312 }
313313 if ( isset( $result ) ) {
314 - // Cache invalidates once per minute
315 - $wgMemc->set( $key, $result, 60 );
 314+ $wgMemc->set( $key, $result, $egFundraiserStatisticsCacheTimeout );
316315 return $result;
317316 }
318317 return null;
Property changes on: branches/wmf/1.16wmf4/extensions/ContributionReporting/FundraiserStatistics_body.php
___________________________________________________________________
Modified: svn:mergeinfo
319318 Merged /trunk/extensions/ContributionReporting/FundraiserStatistics_body.php:r78787

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78787Make Special:FundraiserStatistics cache timeout configurable and set it to 5 ...catrope14:26, 22 December 2010

Status & tagging log