r78756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78755‎ | r78756 | r78757 >
Date:22:34, 21 December 2010
Author:reedy
Status:deferred
Tags:
Comment:
MFT 78504-78751
Modified paths:
  • /branches/querypage-work2/phase3 (modified) (history)
  • /branches/querypage-work2/phase3/RELEASE-NOTES (modified) (history)
  • /branches/querypage-work2/phase3/includes (modified) (history)
  • /branches/querypage-work2/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/ChangesList.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/ConfEditor.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/GlobalFunctions.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/HTMLCacheUpdate.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/HTMLForm.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/ImportXMLReader.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/Interwiki.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/Linker.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/OutputPage.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/Skin.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/SpecialPage.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/Title.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/Token.php (added) (history)
  • /branches/querypage-work2/phase3/includes/Wiki.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/api (modified) (history)
  • /branches/querypage-work2/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/api/ApiUpload.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/db/Database.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/db/DatabaseOracle.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/filerepo/File.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/filerepo/RepoGroup.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/MysqlInstaller.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/OracleUpdater.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/WebInstallerOutput.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/installer/WebInstallerPage.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/json/Services_JSON.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/parser/ParserOptions.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/resourceloader/ResourceLoaderFileModule.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/resourceloader/ResourceLoaderWikiModule.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/specials (modified) (history)
  • /branches/querypage-work2/phase3/includes/specials/SpecialUpload.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/specials/SpecialUploadStash.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/specials/SpecialUserlogin.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/upload/UploadBase.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/upload/UploadFromFile.php (modified) (history)
  • /branches/querypage-work2/phase3/includes/upload/UploadStash.php (modified) (history)
  • /branches/querypage-work2/phase3/index.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/Language.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/LanguageConverter.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/Names.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/classes/LanguageGd.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesAf.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesAs.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesBa.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesBe_tarask.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesBg.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesBjn.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesBo.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesBr.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesBs.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesCrh_cyrl.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesCrh_latn.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesCs.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesCy.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesDa.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesDsb.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesEs.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesFa.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesFi.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesFr.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesFrp.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesFrr.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesGag.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesGl.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesGsw.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesHi.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesHif_latn.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesHr.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesHsb.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesHu.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesId.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesIt.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesJa.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesLb.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesLg.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesMk.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesMl.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesNl.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesNo.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesPl.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesPt.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesPt_br.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesRgn.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesRo.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesRu.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesRue.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesSco.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesShi.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesSi.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesSk.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesSl.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesSma.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesSq.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesSw.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesTa.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesUk.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesVi.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesVot.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesWuu.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesXmf.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesYi.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesZh_hans.php (modified) (history)
  • /branches/querypage-work2/phase3/languages/messages/MessagesZh_hant.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/7zip.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/Maintenance.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/archives (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/archives/upgradeLogging.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/backupPrefetch.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/benchmarks/Benchmarker.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/benchmarks/bench_HTTP_HTTPS.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/benchmarks/bench_wfIsWindows.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/cleanupTable.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/commandLine.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/deleteSelfExternals.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/dumpInterwiki.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/eval.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/fuzz-tester.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/importImages.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/importImages.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/importTextFile.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/importUseModWiki.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/importUseModWikipedia.php (added) (history)
  • /branches/querypage-work2/phase3/maintenance/install-utils.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/install.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/lag.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/StatOutputs.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/checkDupeMessages.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/checkExtensions.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/checkLanguage.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/checkLanguage.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/function-list.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/generateNormalizerData.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/languages.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/messages.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/rebuildLanguage.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/transstat.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/validate.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/language/writeMessagesArray.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/mcc.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/mergeMessageFileList.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/minify.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/mwdocgen.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/ourusers.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/populateCategory.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/populateRevisionLength.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/preprocessorFuzzTest.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/protect.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/purgeOldText.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/rebuildInterwiki.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/refreshLinks.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/sqlite.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/checkStorage.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/compressOld.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/compressOld.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/fixBug20757.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/moveToExternal.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/recompressTracked.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/resolveStubs.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/storageTypeStats.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/testCompression.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/storage/trackBlobs.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/tables.sql (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/undelete.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/update.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/updateCollation.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/upgrade1_5.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/userDupes.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/userOptions.inc (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/userOptions.php (modified) (history)
  • /branches/querypage-work2/phase3/maintenance/waitForSlave.php (modified) (history)
  • /branches/querypage-work2/phase3/resources/Resources.php (modified) (history)
  • /branches/querypage-work2/phase3/resources/jquery/jquery.suggestions.css (modified) (history)
  • /branches/querypage-work2/phase3/resources/mediawiki/mediawiki.js (modified) (history)
  • /branches/querypage-work2/phase3/skins/Vector.php (modified) (history)
  • /branches/querypage-work2/phase3/skins/common/changepassword.js (deleted) (history)
  • /branches/querypage-work2/phase3/skins/vector/screen.css (modified) (history)
  • /branches/querypage-work2/phase3/tests/parser/parserTests.txt (modified) (history)
  • /branches/querypage-work2/phase3/tests/phpunit/Makefile (modified) (history)
  • /branches/querypage-work2/phase3/tests/phpunit/README (modified) (history)
  • /branches/querypage-work2/phase3/tests/phpunit/includes/api/ApiUploadTest.php (modified) (history)
  • /branches/querypage-work2/phase3/tests/phpunit/includes/api/RandomImageGenerator.php (modified) (history)
  • /branches/querypage-work2/phase3/tests/phpunit/includes/api/generateRandomImages.php (modified) (history)
  • /branches/querypage-work2/phase3/tests/phpunit/install-phpunit.sh (modified) (history)
  • /branches/querypage-work2/phase3/tests/phpunit/phpunit.php (modified) (history)

Status & tagging log