r78641 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78640‎ | r78641 | r78642 >
Date:22:40, 20 December 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Fixed sprintf syntax in query and corrected menu array key 'page callback'
Modified paths:
  • /civicrm/trunk/sites/all/modules/wmf_premiums/wmf_premiums.module (modified) (history)

Diff [purge]

Index: civicrm/trunk/sites/all/modules/wmf_premiums/wmf_premiums.module
@@ -15,7 +15,7 @@
1616 $items['admin/settings/wmf_premiums/test'] = array(
1717 'title' => 'Premium insert test',
1818 'access arguments' => array('administer wmf premiums'),
19 - 'page_callback' => 'wmf_premiums_test_insert',
 19+ 'page callback' => 'wmf_premiums_test_insert',
2020 'type' => MENU_CALLBACK,
2121 );
2222
@@ -40,7 +40,7 @@
4141 }
4242
4343 $query = "INSERT INTO civicrm.premiums (tracking_id, contact_id, contribution_id, shirt, shirt_size)
44 - VALUES ( %1, %2, %3, %4, '%5' )";
 44+ VALUES ( %d, %d, %d, %d, '%s' )";
4545
4646 watchdog( 'wmf_premiums', 'Preparing to insert premium data with the following contribution info: %contrib_info', array( '%contrib_info' => print_r( $contribution_info, true )), WATCHDOG_DEBUG );
4747 $result = db_query( $query,

Status & tagging log