r78534 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78533‎ | r78534 | r78535 >
Date:15:43, 17 December 2010
Author:demon
Status:ok
Tags:
Comment:
Same as r78533, but 5 lines down
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -2414,12 +2414,8 @@
24152415 $error = $this->sourceStream( $fp, $lineCallback, $resultCallback, $fname );
24162416 }
24172417 catch ( MWException $e ) {
2418 - if ( defined( "MEDIAWIKI_INSTALL" ) ) {
2419 - $error = $e->getMessage();
2420 - } else {
2421 - fclose( $fp );
2422 - throw $e;
2423 - }
 2418+ fclose( $fp );
 2419+ throw $e;
24242420 }
24252421
24262422 fclose( $fp );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78533Installer can handle exceptions now, also suppress possible permission errors...demon15:40, 17 December 2010

Status & tagging log