r78527 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78526‎ | r78527 | r78528 >
Date:01:20, 17 December 2010
Author:aaron
Status:ok
Tags:
Comment:
* Added problemchanges-list msg
* Added link to pendingchanges-list
* Tab fix in doc comment
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevision.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/PendingChanges.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/ProblemChanges.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/language/PendingChanges.i18n.php
@@ -11,7 +11,7 @@
1212 $messages['en'] = array(
1313 'pendingchanges' => 'Pages with pending changes',
1414 'pendingchanges-legend' => 'List reviewed pages with pending changes',
15 - 'pendingchanges-list' => 'This page lists reviewed pages having one or more edits awaiting review.',
 15+ 'pendingchanges-list' => 'This page lists [[{{MediaWiki:Validationpage}}|reviewed]] pages having one or more edits awaiting review.',
1616 'pendingchanges-none' => 'There are currently no pages meeting these criteria',
1717 'pendingchanges-hours' => '($1 {{PLURAL:$1|hour|hours}})',
1818 'pendingchanges-days' => '($1 {{PLURAL:$1|day|days}})',
Index: trunk/extensions/FlaggedRevs/language/ProblemChanges.i18n.php
@@ -10,6 +10,7 @@
1111
1212 $messages['en'] = array(
1313 'problemchanges' => 'Tagged pending changes',
 14+ 'problemchanges-list' => 'This page lists [[{{MediaWiki:Validationpage}}|reviewed]] pages having one or more tagged edits awaiting review. A list of valid change tags can be found at [[Special:Tags]].',
1415 'problemchanges-legend' => 'List pages with tagged edits pending review',
1516 'problemchanges-none' => 'There are currently no pages meeting these criteria',
1617 'problemchanges-category' => 'Category:',
Index: trunk/extensions/FlaggedRevs/FlaggedRevision.php
@@ -602,8 +602,8 @@
603603 * (c) ( rev at time of review ) if FR_INCLUDES_FREEZE
604604 * Pending changes exist for a template iff the template is used in
605605 * the current rev of this page and one of the following holds:
606 - * (a) Current template is newer than the "version used" above (updated)
607 - * (b) Current template exists and the "version used" was non-existing (created)
 606+ * (a) Current template is newer than the "version used" above (updated)
 607+ * (b) Current template exists and the "version used" was non-existing (created)
608608 * (c) Current template doesn't exist and the "version used" existed (deleted)
609609 *
610610 * @return Array of (template title, rev ID in reviewed version) tuples
@@ -671,8 +671,8 @@
672672 * (c) ( rev at time of review ) if FR_INCLUDES_FREEZE
673673 * Pending changes exist for a file iff the file is used in
674674 * the current rev of this page and one of the following holds:
675 - * (a) Current file is newer than the "version used" above (updated)
676 - * (b) Current file exists and the "version used" was non-existing (created)
 675+ * (a) Current file is newer than the "version used" above (updated)
 676+ * (b) Current file exists and the "version used" was non-existing (created)
677677 * (c) Current file doesn't exist and the "version used" existed (deleted)
678678 *
679679 * @param string $noForeign Using 'noForeign' skips new non-local file versions (bug 15748)
Index: trunk/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php
@@ -41,6 +41,8 @@
4242
4343 public function showList( $par ) {
4444 global $wgOut, $wgScript;
 45+ // Add explanatory text
 46+ $wgOut->addWikiMsg( 'problemchanges-list' );
4547 $limit = $this->parseParams( $par );
4648 $pager = new ProblemChangesPager( $this, $this->level, $this->category, $this->tag );
4749 // Apply limit if transcluded

Status & tagging log