r78524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78523‎ | r78524 | r78525 >
Date:23:36, 16 December 2010
Author:tparscal
Status:deferred
Tags:
Comment:
Changed some of the attributes names.
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/sql/ArticleFeedback.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/sql/ArticleFeedback.sql
@@ -8,8 +8,8 @@
99
1010 -- Default article feedback ratings for the pilot
1111 INSERT INTO /*$wgDBprefix*/article_feedback_ratings (aar_rating) VALUES
12 -('articlefeedback-rating-wellsourced'), ('articlefeedback-rating-neutrality'),
13 -('articlefeedback-rating-completeness'), ('articlefeedback-rating-readability');
 12+('articlefeedback-rating-trustworthy'), ('articlefeedback-rating-unbiased'),
 13+('articlefeedback-rating-complete'), ('articlefeedback-rating-wellwritten');
1414
1515 -- Store article feedbacks (user rating per revision)
1616 CREATE TABLE IF NOT EXISTS /*$wgDBprefix*/article_feedback (
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
@@ -13,14 +13,14 @@
1414 'scripts' => 'ext.articleFeedback/ext.articleFeedback.js',
1515 'styles' => 'ext.articleFeedback/ext.articleFeedback.css',
1616 'messages' => array(
17 - 'articlefeedback-field-wellsourced-label',
18 - 'articlefeedback-field-wellsourced-tip',
 17+ 'articlefeedback-field-trustworthy-label',
 18+ 'articlefeedback-field-trustworthy-tip',
1919 'articlefeedback-field-complete-label',
2020 'articlefeedback-field-complete-tip',
21 - 'articlefeedback-field-neutral-label',
22 - 'articlefeedback-field-neutral-tip',
23 - 'articlefeedback-field-readable-label',
24 - 'articlefeedback-field-readable-tip',
 21+ 'articlefeedback-field-unbiased-label',
 22+ 'articlefeedback-field-unbiased-tip',
 23+ 'articlefeedback-field-wellwritten-label',
 24+ 'articlefeedback-field-wellwritten-tip',
2525 ),
2626 'dependencies' => array(
2727 'jquery.articleFeedback',
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -25,9 +25,6 @@
2626 <div style="clear:both;"></div>\
2727 </div>\
2828 </div>\
29 -<div class="articleFeedback-dialog" rel="survey"><div class="articleFeedback-buffer"><div class="articleFeedback-title">Take a survey?</div></div></div>\
30 -<div class="articleFeedback-dialog" rel="register"><div class="articleFeedback-buffer"><div class="articleFeedback-title">Create an account?</div></div></div>\
31 -<div class="articleFeedback-dialog" rel="edit"><div class="articleFeedback-buffer"><div class="articleFeedback-title">Edit a page?</div></div></div>\
3229 ',
3330 'rating': '\
3431 <div class="articleFeedback-rating">\
@@ -39,6 +36,13 @@
4037 <div class="articleFeedback-rating-count articleFeedback-visibleWith-report"></div>\
4138 <div style="clear:both;"></div>\
4239 </div>\
 40+ ',
 41+ 'dialog': '\
 42+<div class="articleFeedback-dialog">\
 43+ <div class="articleFeedback-buffer">\
 44+ <div class="articleFeedback-title"></div>\
 45+ </div>\
 46+</div>\
4347 '
4448 },
4549 'fn': {
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -6,25 +6,25 @@
77
88 var config = {
99 'ratings': {
10 - 'wellsourced': {
 10+ 'trustworthy': {
1111 'id': '1',
12 - 'label': 'articlefeedback-field-wellsourced-label',
13 - 'tip': 'articlefeedback-field-wellsourced-tip'
 12+ 'label': 'articlefeedback-field-trustworthy-label',
 13+ 'tip': 'articlefeedback-field-trustworthy-tip'
1414 },
15 - 'neutral': {
 15+ 'unbiased': {
1616 'id': '2',
17 - 'label': 'articlefeedback-field-neutral-label',
18 - 'tip': 'articlefeedback-field-neutral-tip'
 17+ 'label': 'articlefeedback-field-unbiased-label',
 18+ 'tip': 'articlefeedback-field-unbiased-tip'
1919 },
2020 'complete': {
2121 'id': '3',
2222 'label': 'articlefeedback-field-complete-label',
2323 'tip': 'articlefeedback-field-complete-tip'
2424 },
25 - 'readable': {
 25+ 'wellwritten': {
2626 'id': '4',
27 - 'label': 'articlefeedback-field-readable-label',
28 - 'tip': 'articlefeedback-field-readable-tip'
 27+ 'label': 'articlefeedback-field-wellwritten-label',
 28+ 'tip': 'articlefeedback-field-wellwritten-tip'
2929 }
3030 }
3131 };
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -36,14 +36,14 @@
3737 'articlefeedback-report-panel-description' => 'Current average ratings.',
3838 'articlefeedback-report-empty' => 'No ratings',
3939 'articlefeedback-report-ratings' => '$1 ratings',
40 - 'articlefeedback-field-wellsourced-label' => 'Well-sourced',
41 - 'articlefeedback-field-wellsourced-tip' => 'Do you feel this page has sufficient citations and that those citations come from trustworthy sources?',
 40+ 'articlefeedback-field-trustworthy-label' => 'Trustworthy',
 41+ 'articlefeedback-field-trustworthy-tip' => 'Do you feel this page has sufficient citations and that those citations come from trustworthy sources?',
4242 'articlefeedback-field-complete-label' => 'Complete',
4343 'articlefeedback-field-complete-tip' => 'Do you feel that this page covers the essential topic areas that it should?',
44 - 'articlefeedback-field-neutral-label' => 'Neutral',
45 - 'articlefeedback-field-neutral-tip' => 'Do you feel that this page shows a fair representation of all perspectives on the issue?',
46 - 'articlefeedback-field-readable-label' => 'Readable',
47 - 'articlefeedback-field-readable-tip' => 'Do you feel that this page is well-organized and well written?',
 44+ 'articlefeedback-field-unbiased-label' => 'Unbiased',
 45+ 'articlefeedback-field-unbiased-tip' => 'Do you feel that this page shows a fair representation of all perspectives on the issue?',
 46+ 'articlefeedback-field-wellwritten-label' => 'Well-written',
 47+ 'articlefeedback-field-wellwritten-tip' => 'Do you feel that this page is well-organized and well-written?',
4848 );
4949
5050 /** Message documentation (Message documentation)

Status & tagging log