r78504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78503‎ | r78504 | r78505 >
Date:18:30, 16 December 2010
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r77762 per CR, and an unrelated one-character whitespace fix which doesn't deserve its own revision id... :D
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/tests/phpunit/phpunit.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/phpunit.php
@@ -9,7 +9,7 @@
1010 /* Configuration */
1111
1212 // Evaluate the include path relative to this file
13 -$IP = dirname( dirname( dirname( __FILE__ ) ) );
 13+$IP = dirname( dirname( dirname( __FILE__ ) ) );
1414
1515 // Set a flag which can be used to detect when other scripts have been entered through this entry point or not
1616 define( 'MW_PHPUNIT_TEST', true );
Index: trunk/phase3/includes/Skin.php
@@ -2063,24 +2063,24 @@
20642064 * Return a fully resolved style path url to images or styles stored in the common folder.
20652065 * This method returns a url resolved using the configured skin style path
20662066 * and includes the style version inside of the url.
2067 - * @param $name String: The name or path of the common file to return the full path for.
 2067+ * @param $name String: The name or path of a skin resource file
20682068 * @return String The fully resolved style path url including styleversion
20692069 */
20702070 function getCommonStylePath( $name ) {
20712071 global $wgStylePath, $wgStyleVersion;
2072 - return "{$wgStylePath}/common/$name?{$wgStyleVersion}";
 2072+ return "$wgStylePath/common/$name?$wgStyleVersion";
20732073 }
20742074
20752075 /**
20762076 * Return a fully resolved style path url to images or styles stored in the curent skins's folder.
20772077 * This method returns a url resolved using the configured skin style path
20782078 * and includes the style version inside of the url.
2079 - * @param $name String: The name or path of the skin resource file to return the full path for.
 2079+ * @param $name String: The name or path of a skin resource file
20802080 * @return String The fully resolved style path url including styleversion
20812081 */
20822082 function getSkinStylePath( $name ) {
20832083 global $wgStylePath, $wgStyleVersion;
2084 - return "{$wgStylePath}/{$this->stylename}/$name?{$wgStyleVersion}";
 2084+ return "$wgStylePath/{$this->stylename}/$name?$wgStyleVersion";
20852085 }
20862086
20872087 /* these are used extensively in SkinTemplate, but also some other places */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77762Add method documentation for getCommonStylePath and getSkinStylePath.dantman04:22, 5 December 2010

Status & tagging log