r78433 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78432‎ | r78433 | r78434 >
Date:11:30, 15 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove public from interface defintion, as decleration in an interface is not valid
Modified paths:
  • /trunk/phase3/includes/HistoryBlob.php (modified) (history)
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -729,24 +729,24 @@
730730 * @param $code Language code
731731 * @param $key Cache key
732732 */
733 - public function get( $code, $key );
 733+ function get( $code, $key );
734734
735735 /**
736736 * Start a write transaction.
737737 * @param $code Language code
738738 */
739 - public function startWrite( $code );
 739+ function startWrite( $code );
740740
741741 /**
742742 * Finish a write transaction.
743743 */
744 - public function finishWrite();
 744+ function finishWrite();
745745
746746 /**
747747 * Set a key to a given value. startWrite() must be called before this
748748 * is called, and finishWrite() must be called afterwards.
749749 */
750 - public function set( $key, $value );
 750+ function set( $key, $value );
751751
752752 }
753753
Index: trunk/phase3/includes/HistoryBlob.php
@@ -14,14 +14,14 @@
1515 *
1616 * @return String: the key for getItem()
1717 */
18 - public function addItem( $text );
 18+ function addItem( $text );
1919
2020 /**
2121 * Get item by key, or false if the key is not present
2222 *
2323 * @return String or false
2424 */
25 - public function getItem( $key );
 25+ function getItem( $key );
2626
2727 /**
2828 * Set the "default text"
@@ -31,7 +31,7 @@
3232 *
3333 * Default text is not required for two-part external storage URLs.
3434 */
35 - public function setText( $text );
 35+ function setText( $text );
3636
3737 /**
3838 * Get default text. This is called from Revision::getRevisionText()

Status & tagging log