r78401 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78400‎ | r78401 | r78402 >
Date:21:30, 14 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Minor followup to r78394, cache result of getLimitForm call, and use that
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeCommentsListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeStatusChangeListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeCommentsListView.php
@@ -12,11 +12,12 @@
1313 function execute() {
1414 global $wgOut;
1515 $pager = $this->getPager();
 16+ $limitForm = $pager->getLimitForm();
1617 $wgOut->addHTML(
1718 $pager->getNavigationBar() .
18 - $pager->getLimitForm() .
 19+ $limitForm .
1920 $pager->getBody() .
20 - $pager->getLimitForm() .
 21+ $limitForm .
2122 $pager->getNavigationBar()
2223 );
2324 }
Index: trunk/extensions/CodeReview/ui/CodeStatusChangeListView.php
@@ -12,11 +12,12 @@
1313 function execute() {
1414 global $wgOut;
1515 $pager = $this->getPager();
 16+ $limitForm = $pager->getLimitForm();
1617 $wgOut->addHTML(
1718 $pager->getNavigationBar() .
18 - $pager->getLimitForm() .
 19+ $limitForm .
1920 $pager->getBody() .
20 - $pager->getLimitForm() .
 21+ $limitForm .
2122 $pager->getNavigationBar()
2223 );
2324 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78394Show limit form at bottom of CodeCommentsListView and CodeStatusChangeListViewreedy17:55, 14 December 2010

Status & tagging log