r78378 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78377‎ | r78378 | r78379 >
Date:13:37, 14 December 2010
Author:demon
Status:ok
Tags:
Comment:
Cleanup for r63578: Use Maintenance::error(), that's what its for
Modified paths:
  • /trunk/phase3/maintenance/updateDoubleWidthSearch.php (modified) (history)
  • /trunk/phase3/maintenance/updateSearchIndex.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/updateSearchIndex.php
@@ -70,10 +70,10 @@
7171 fwrite( $file, $end );
7272 fclose( $file );
7373 } else {
74 - $this->output( "*** Couldn't write to the $posFile!\n" );
 74+ $this->error( "*** Couldn't write to the $posFile!\n" );
7575 }
7676 } else {
77 - $this->output( "*** Couldn't write to the $posFile!\n" );
 77+ $this->error( "*** Couldn't write to the $posFile!\n" );
7878 }
7979 }
8080
Index: trunk/phase3/maintenance/updateDoubleWidthSearch.php
@@ -43,8 +43,7 @@
4444
4545 $dbw = wfGetDB( DB_MASTER );
4646 if ( $dbw->getType() !== 'mysql' ) {
47 - $this->output( "This change is only needed on MySQL, quitting.\n" );
48 - exit( 1 );
 47+ $this->error( "This change is only needed on MySQL, quitting.\n", true );
4948 }
5049
5150 $res = $this->findRows( $dbw );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63578Follow-up r61856...mah21:54, 10 March 2010

Status & tagging log