r78364 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78363‎ | r78364 | r78365 >
Date:10:57, 14 December 2010
Author:tstarling
Status:ok
Tags:
Comment:
Update references for wfEscapeShellArg() for r69732 etc. The very useful mailing list post that I cited has disappeared from the web!
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -1442,8 +1442,12 @@
14431443 }
14441444
14451445 if ( wfIsWindows() ) {
1446 - // Escaping for an MSVC-style command line parser
1447 - // Ref: http://mailman.lyra.org/pipermail/scite-interest/2002-March/000436.html
 1446+ // Escaping for an MSVC-style command line parser and CMD.EXE
 1447+ // Refs:
 1448+ // * http://web.archive.org/web/20020708081031/http://mailman.lyra.org/pipermail/scite-interest/2002-March/000436.html
 1449+ // * http://technet.microsoft.com/en-us/library/cc723564.aspx
 1450+ // * Bug #13518
 1451+ // * CR r63214
14481452 // Double the backslashes before any double quotes. Escape the double quotes.
14491453 $tokens = preg_split( '/(\\\\*")/', $arg, -1, PREG_SPLIT_DELIM_CAPTURE );
14501454 $arg = '';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69732Follow up r63214, and its revert r69201. The rules were more complex than a ...platonides16:04, 22 July 2010

Status & tagging log