r78360 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78359‎ | r78360 | r78361 >
Date:09:01, 14 December 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fixed comments and indenting style from r68491.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -1829,9 +1829,10 @@
18301830 $text = $link;
18311831 } else {
18321832 # Bug 4598 madness. Handle the quotes only if they come from the alternate part
1833 - # [[Lista d''e paise d''o munno]] -> <a href="">Lista d''e paise d''o munno</a>
1834 - # [[Criticism of Harry Potter|Criticism of ''Harry Potter'']] -> <a href="Criticism of Harry Potter">Criticism of <i>Harry Potter</i></a>
1835 - $text = $this->doQuotes($text);
 1833+ # [[Lista d''e paise d''o munno]] -> <a href="...">Lista d''e paise d''o munno</a>
 1834+ # [[Criticism of Harry Potter|Criticism of ''Harry Potter'']]
 1835+ # -> <a href="Criticism of Harry Potter">Criticism of <i>Harry Potter</i></a>
 1836+ $text = $this->doQuotes( $text );
18361837 }
18371838
18381839 # Link not escaped by : , create the various objects
Index: trunk/phase3/includes/Linker.php
@@ -712,8 +712,8 @@
713713
714714 wfProfileOut( __METHOD__ );
715715 return '<a href="' . htmlspecialchars( $href ) . '" class="new" title="' .
716 - htmlspecialchars( $title->getPrefixedText(), ENT_QUOTES ) . '">' .
717 - htmlspecialchars( $prefix . $text . $inside, ENT_NOQUOTES ) . '</a>' . $trail;
 716+ htmlspecialchars( $title->getPrefixedText(), ENT_QUOTES ) . '">' .
 717+ htmlspecialchars( $prefix . $text . $inside, ENT_NOQUOTES ) . '</a>' . $trail;
718718 } else {
719719 wfProfileOut( __METHOD__ );
720720 return $this->linkKnown( $title, "$prefix$text$inside", array(), $query ) . $trail;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68491Disable pretty italics inside links. Now the italics inside a link alternate ...platonides23:29, 23 June 2010

Status & tagging log