r78341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78340‎ | r78341 | r78342 >
Date:23:32, 13 December 2010
Author:yaron
Status:deferred
Tags:
Comment:
Removed $sfgAutocompleteDataTypes global variable
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.php
@@ -10,10 +10,8 @@
1111
1212 class SFFormUtils {
1313 static function setGlobalJSVariables( &$vars ) {
14 - global $sfgAdderButtons;
15 - global $sfgAutocompleteDataTypes, $sfgAutocompleteValues;
16 - global $sfgAutocompleteOnAllChars;
17 - global $sfgShowOnSelect;
 14+ global $sfgAdderButtons, $sfgShowOnSelect;
 15+ global $sfgAutocompleteValues, $sfgAutocompleteOnAllChars;
1816
1917 $vars['sfgRemoveText'] = wfMsg( 'sf_formedit_remove' );
2018 $vars['sfgAdderButtons'] = $sfgAdderButtons;
@@ -21,7 +19,6 @@
2220 // variables that are associative arrays need to be cast as
2321 // objects, to work with MW 1.15 and earlier
2422 $vars['sfgAutocompleteValues'] = (object)$sfgAutocompleteValues;
25 - $vars['sfgAutocompleteDataTypes'] = (object)$sfgAutocompleteDataTypes;
2623 $vars['sfgShowOnSelect'] = (object)$sfgShowOnSelect;
2724 $vars['sfgFormErrorsHeader'] = wfMsg( 'sf_formerrors_header' );
2825 $vars['sfgBlankErrorStr'] = wfMsg( 'sf_blank_error' );
Index: trunk/extensions/SemanticForms/includes/SF_Settings.php
@@ -117,5 +117,4 @@
118118 # ##
119119 $sfgAdderButtons = array();
120120 $sfgShowOnSelect = array();
121 -$sfgAutocompleteDataTypes = array();
122121 $sfgAutocompleteValues = array();

Status & tagging log