r78335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78334‎ | r78335 | r78336 >
Date:22:15, 13 December 2010
Author:yaron
Status:deferred
Tags:
Comment:
$sfgAutocompleteMappings variable removed, replaced by new 'autocompletesettings' attribute within form input
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php
@@ -271,8 +271,7 @@
272272 SFUtils::addJavascriptAndCSS();
273273 }
274274 $autocompletion_values = SFUtils::getAutocompleteValues( $inAutocompletionSource, $autocompletion_type );
275 - global $sfgAutocompleteMappings, $sfgAutocompleteValues;
276 - $sfgAutocompleteMappings[$input_num] = "input_$input_num";
 275+ global $sfgAutocompleteValues;
277276 $sfgAutocompleteValues["input_$input_num"] = $autocompletion_values;
278277 }
279278
@@ -287,7 +286,7 @@
288287 } else {
289288 $str = <<<END
290289 <form name="createbox" action="$fs_url" method="get">
291 - <p><input type="text" name="page_name" id="input_$input_num" size="$inSize" value="$inValue" class="autocompleteInput createboxInput formInput" />
 290+ <p><input type="text" name="page_name" id="input_$input_num" size="$inSize" value="$inValue" class="autocompleteInput createboxInput formInput" autocompletesettings="input_$input_num" />
292291
293292 END;
294293 }

Status & tagging log