r78245 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78244‎ | r78245 | r78246 >
Date:15:29, 12 December 2010
Author:demon
Status:ok
Tags:
Comment:
Per CR on r71359: Fix DB_MASTER where it should be __METHOD__
Modified paths:
  • /trunk/phase3/maintenance/convertLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/convertLinks.php
@@ -193,12 +193,12 @@
194194 if ( $overwriteLinksTable ) {
195195 # Check for existing links_backup, and delete it if it exists.
196196 $this->output( "Dropping backup links table if it exists..." );
197 - $dbw->query( "DROP TABLE IF EXISTS $links_backup", DB_MASTER );
 197+ $dbw->query( "DROP TABLE IF EXISTS $links_backup", __METHOD__ );
198198 $this->output( " done.\n" );
199199
200200 # Swap in the new table, and move old links table to links_backup
201201 $this->output( "Swapping tables '$links' to '$links_backup'; '$links_temp' to '$links'..." );
202 - $dbw->query( "RENAME TABLE links TO $links_backup, $links_temp TO $links", DB_MASTER );
 202+ $dbw->query( "RENAME TABLE links TO $links_backup, $links_temp TO $links", __METHOD__ );
203203 $this->output( " done.\n\n" );
204204
205205 $dbw->close();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71359Refactor convertLinks to not use DB::newFromParams() crap, make updaters use ...demon14:47, 20 August 2010

Status & tagging log