r78239 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78238‎ | r78239 | r78240 >
Date:09:06, 12 December 2010
Author:laner
Status:deferred
Tags:
Comment:
Ensuring creation will occur if no extensions are using the hook.
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -749,8 +749,9 @@
750750 $values["userpassword"] = $pass;
751751 $values["objectclass"] = array( "inetorgperson" );
752752
 753+ $result = true;
753754 # Let other extensions modify the user object before creation
754 - wfRunHooks( 'LDAPSetCreationValues', array( $this, &$values, &$result ) );
 755+ wfRunHooks( 'LDAPSetCreationValues', array( $this, $username, &$values, &$result ) );
755756 if ( ! $result ) {
756757 $this->printDebug( "Failed to add user because LDAPSetCreationValues returned false", NONSENSITIVE );
757758 @ldap_unbind();

Status & tagging log