r78193 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78192‎ | r78193 | r78194 >
Date:15:28, 10 December 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Added extra info about the targets on the tab interface
Modified paths:
  • /trunk/extensions/Push/Push.i18n.php (modified) (history)
  • /trunk/extensions/Push/Push.php (modified) (history)
  • /trunk/extensions/Push/README (modified) (history)
  • /trunk/extensions/Push/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Push/includes/Push_Tab.php (modified) (history)
  • /trunk/extensions/Push/includes/ext.push.tab.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Push/Push.i18n.php
@@ -42,6 +42,7 @@
4343 'push-remote-page-link-full' => 'View $1 on $2',
4444 'push-targets-total' => 'There a total of $1 {{PLURAL:$1|target|targets}}.',
4545 'push-button-all' => 'Push all',
 46+ 'push-tab-last-edit' => 'Last edit by $1 on $2 at $3.',
4647
4748 // Special page
4849 'special-push' => 'Push pages',
Index: trunk/extensions/Push/Push.php
@@ -22,7 +22,7 @@
2323 die( 'Not an entry point.' );
2424 }
2525
26 -define( 'Push_VERSION', '0.3' );
 26+define( 'Push_VERSION', '0.4 alpha' );
2727
2828 $wgExtensionCredits['other'][] = array(
2929 'path' => __FILE__,
@@ -76,6 +76,7 @@
7777 'push-special-item-failed',
7878 'push-special-push-done',
7979 'push-err-captacha',
 80+ 'push-tab-last-edit',
8081 );
8182
8283 // For backward compatibility with MW < 1.17.
Index: trunk/extensions/Push/RELEASE-NOTES
@@ -4,6 +4,11 @@
55 Latest version of the release notes: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Push/RELEASE-NOTES?view=co
66
77
 8+=== Version 0.4 ===
 9+2010-12-xx
 10+
 11+*
 12+
813 === Version 0.3 ===
914 2010-12-10
1015
Index: trunk/extensions/Push/includes/Push_Tab.php
@@ -185,7 +185,7 @@
186186 array(),
187187 Html::element(
188188 'th',
189 - array(),
 189+ array( 'width' => '200px' ),
190190 wfMsg( 'push-targets' )
191191 ) .
192192 Html::element(
@@ -271,6 +271,13 @@
272272 'id' => 'targetlink' . $targetId
273273 ),
274274 wfMsgExt( 'push-remote-page-link', 'parsemag', $wgTitle->getFullText(), $name )
 275+ ) .
 276+ Html::element(
 277+ 'div',
 278+ array(
 279+ 'id' => 'targetinfo' . $targetId,
 280+ 'style' => 'display:none'
 281+ )
275282 )
276283 ) .
277284 Html::rawElement(
Index: trunk/extensions/Push/includes/ext.push.tab.js
@@ -63,6 +63,17 @@
6464 if ( first == '-1' ) {
6565 $( '#targetlink' + targetId ).attr( {'class': 'new'} );
6666 }
 67+ else {
 68+ var revision = data.query.pages[first].revisions[0];
 69+ var dateTime = revision.timestamp.split( 'T' );
 70+ $( '#targetinfo' + targetId ).css( 'color', 'darkgray' );
 71+ $( '#targetinfo' + targetId ).text( mediaWiki.msg(
 72+ 'push-tab-last-edit',
 73+ revision.user,
 74+ dateTime[0],
 75+ dateTime[1].replace( 'Z', '' )
 76+ ) ).fadeIn('slow');
 77+ }
6778 }
6879 }
6980 );
Index: trunk/extensions/Push/README
@@ -5,5 +5,5 @@
66
77 == About ==
88
9 -The Push extension is a simple leightwieght tool that adds an extra tab to artciles that
10 -allows users to push the content of the article to another MediaWiki wiki.
\ No newline at end of file
 9+The Push extension is a simple lightweight tool that adds an extra tab to articles which
 10+enables users to push the content of the article to one or more other MediaWiki wikis.
\ No newline at end of file

Status & tagging log