r78110 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78109‎ | r78110 | r78111 >
Date:02:32, 9 December 2010
Author:reedy
Status:deferred
Tags:
Comment:
Followup r78108, rename GNSM to GoogleNewsSitemap again
Modified paths:
  • /trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap.php (modified) (history)
  • /trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php
@@ -6,7 +6,7 @@
77 **
88 * Simple feed using Atom/RSS coupled to DynamicPageList category searching.
99 *
10 - * To use: http://wiki.url/Special:GNSM/[paramter=value][...]
 10+ * To use: http://wiki.url/Special:GoogleNewsSitemap/[paramter=value][...]
1111 *
1212 * Implemented parameters are marked with an @
1313 **
@@ -26,9 +26,7 @@
2727 * suppresserrors = bool ; default = false
2828 **/
2929
30 -class GNSM extends IncludableSpecialPage {
31 -
32 -
 30+class GoogleNewsSitemap extends IncludableSpecialPage {
3331 /**
3432 * FIXME: Some of this might need a config eventually
3533 * @var string
@@ -65,7 +63,7 @@
6664 * Constructor
6765 **/
6866 public function __construct() {
69 - parent::__construct( 'GNSM' );
 67+ parent::__construct( 'GoogleNewsSitemap' );
7068 }
7169
7270 /**
@@ -78,7 +76,7 @@
7977 global $wgRequest, $wgOut;
8078 global $wgSitename, $wgServer, $wgScriptPath;
8179 // global $wfTimeStamp;
82 - wfLoadExtensionMessages( 'GNSM' );
 80+ wfLoadExtensionMessages( 'GoogleNewsSitemap' );
8381 global $wgFeedClasses, $wgLocaltimezone;
8482
8583 // Not sure how clean $wgLocaltimezone is
@@ -327,7 +325,7 @@
328326 $this->params['catCount'] = count( $this->categories );
329327 }else{
330328 echo "\$feed is not an object.\n";
331 - continue;
 329+ //continue;
332330 }
333331 }
334332
Index: trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap.php
@@ -1,8 +1,8 @@
22 <?php
33 if (!defined('MEDIAWIKI')) {
44 echo <<<EOT
5 -To install GNSM extension, an extension special page, put the following line in LocalSettings.php:
6 -require_once( dirname(__FILE__) . '/extensions/GNSM/SpecialGNSM.php' );
 5+To install GoogleNewsSitemap extension, an extension special page, put the following line in LocalSettings.php:
 6+require_once( dirname(__FILE__) . '/extensions/GoogleNewsSitemap/GoogleNewsSitemap.php' );
77 EOT;
88 exit( 1 );
99 }
@@ -17,11 +17,11 @@
1818 * - 0.92 http://www.rssboard.org/rss-0-9-2
1919 * Atom feed output - 2005 http://tools.ietf.org/html/rfc4287
2020 **
21 - * This page can be accessed from Special:GNSM[/][|category=Catname]
 21+ * This page can be accessed from Special:GoogleNewsSitemap[/][|category=Catname]
2222 * [|notcategory=OtherCatName][|namespace=0][|notnamespace=User]
2323 * [|feed=sitemap][|count=10][|mode=ul][|ordermethod=lastedit]
2424 * [|order=ascending] as well as being included like
25 - * {{Special:GNSM/[options][...]}}
 25+ * {{Special:GoogleNewsSitemap/[options][...]}}
2626 **
2727 * This program is free software; you can redistribute it and/or modify it
2828 * under the terms of the GNU General Public License as published by the Free
@@ -45,7 +45,7 @@
4646 * n:en:User:IlyaHaykinson http://en.wikinews.org/wiki/User:IlyaHaykinson
4747 **
4848 * FIXME requests
49 - * use=Mediawiki:GNSM_Feedname Parameter to allow on-site control of feed
 49+ * use=Mediawiki:GoogleNewsSitemap_Feedname Parameter to allow on-site control of feed
5050 **
5151 * @addtogroup Extensions
5252 *
@@ -55,15 +55,15 @@
5656 */
5757 $wgExtensionCredits['specialpage'][] = array(
5858 'path' => __FILE__,
59 - 'name' => 'GNSM',
 59+ 'name' => 'GoogleNewsSitemap',
6060 'author' => 'Amgine',
6161 'description' => 'Outputs xml based on defined criteria',
6262 'descriptionmsg' => 'gnsm-desc',
63 - 'url' => 'http://www.mediawiki.org/wiki/Extension:GNSM',
 63+ 'url' => 'http://www.mediawiki.org/wiki/Extension:GoogleNewsSitemap',
6464 );
6565
6666 $dir = dirname(__FILE__) . '/';
67 -$wgExtensionMessagesFiles['GNSM'] = $dir . 'GoogleNewsSitemap.i18n.php';
68 -$wgExtensionAliasesFiles['GNSM'] = $dir . 'GoogleNewsSitemap.alias.php';
69 -$wgAutoloadClasses['GNSM'] = $dir . 'GoogleNewsSitemap_body.php';
70 -$wgSpecialPages['GNSM'] = 'GNSM';
 67+$wgExtensionMessagesFiles['GoogleNewsSitemap'] = $dir . 'GoogleNewsSitemap.i18n.php';
 68+$wgExtensionAliasesFiles['GoogleNewsSitemap'] = $dir . 'GoogleNewsSitemap.alias.php';
 69+$wgAutoloadClasses['GoogleNewsSitemap'] = $dir . 'GoogleNewsSitemap_body.php';
 70+$wgSpecialPages['GoogleNewsSitemap'] = 'GoogleNewsSitemap';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78108Changes by Jason Gigliokim02:19, 9 December 2010

Status & tagging log