r78089 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78088‎ | r78089 | r78090 >
Date:19:33, 8 December 2010
Author:tparscal
Status:ok
Tags:
Comment:
Moved button styles from dialog specific areas to button specific areas to make all buttons look similar.
Modified paths:
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css (modified) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.dialog.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.dialog.css
@@ -8,7 +8,7 @@
99 .ui-dialog .ui-dialog-titlebar-close:hover, .ui-dialog .ui-dialog-titlebar-close:focus { padding: 0; }
1010 .ui-dialog .ui-dialog-content { border: 0; padding: .5em 1em; background: none; overflow: auto; zoom: 1; }
1111 .ui-dialog .ui-dialog-buttonpane { text-align: left; border-width: 1px 0 0 0; background-image: none; margin: .5em 0 0 0; padding: .3em 1em .5em .4em; }
12 -.ui-dialog .ui-dialog-buttonpane button { float: right; margin: .5em .4em .5em 0; cursor: pointer; padding: .2em .6em .3em .6em; line-height: 1.4em; width:auto; overflow:visible; }
 12+.ui-dialog .ui-dialog-buttonpane button { float: right; }
1313 .ui-dialog .ui-resizable-se { width: 14px; height: 14px; right: 3px; bottom: 3px; }
1414 .ui-draggable .ui-dialog-titlebar { cursor: move; }
1515 /* Customizations */
@@ -22,32 +22,6 @@
2323 body .ui-dialog .ui-dialog-titlebar {
2424 padding: 0.9em 1.4em 0.6em !important;
2525 }
26 -body .ui-dialog .ui-dialog-buttonpane button {
27 - -moz-border-radius: 4px;
28 - -webkit-border-radius: 4px;
29 - padding: 0.2em 0.6em 0.15em !important;
30 - margin: 0.5em 0 0.5em 0.4em !important;
31 - border: 1px solid #a6a6a6 !important;
32 - background: #f2f2f2 url(images/button-off.png) repeat-x scroll 50% 100% !important;
33 -}
34 -body .ui-dialog .ui-dialog-buttonpane button:hover {
35 - border-color: #6e7273;
36 - background: #e1e1e1 url(images/button-over.png) repeat-x scroll 50% 100% !important;
37 -}
38 -body .ui-dialog .ui-dialog-buttonpane button:active,
39 -body .ui-dialog .ui-dialog-buttonpane button:focus {
40 - border-color: #707271;
41 - background: #bfbfbf url(images/button-down.png) repeat-x scroll 50% 100% !important;
42 -}
43 -body .ui-dialog .ui-dialog-buttonpane button.disabled {
44 - color: #7f7f7f;
45 - border-color: #cccccc;
46 - background: #f2f2f2 url(images/button-disabled.png) repeat-x scroll 50% 100% !important;
47 -}
48 -/* Disables the annoying dashed border Firefox puts on active buttons */
49 -body .ui-dialog .ui-dialog-buttonpane button::-moz-focus-inner {
50 - border: 0;
51 -}
5226 body .ui-dialog .ui-widget-header {
5327 background: #f0f0f0 url(images/titlebar-fade.png) repeat-x scroll 50% 100% !important;
5428 }
Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css
@@ -29,7 +29,35 @@
3030 /* workarounds */
3131 button.ui-button::-moz-focus-inner { border: 0; padding: 0; } /* reset extra padding in Firefox */
3232
 33+body button.ui-button {
 34+ -moz-border-radius: 4px;
 35+ -webkit-border-radius: 4px;
 36+ padding: 0.2em 0.6em 0.15em !important;
 37+ margin: 0.5em 0 0.5em 0.4em !important;
 38+ border: 1px solid #a6a6a6 !important;
 39+ background: #f2f2f2 url(images/button-off.png) repeat-x scroll 50% 100% !important;
 40+ cursor: pointer;
 41+ font-size: 1em;
 42+ line-height: 1.4em;
 43+ width: auto;
 44+ overflow: visible;
 45+}
 46+body button.ui-button:hover {
 47+ border-color: #6e7273;
 48+ background: #e1e1e1 url(images/button-over.png) repeat-x scroll 50% 100% !important;
 49+}
 50+body button.ui-button:active,
 51+body button.ui-button:focus {
 52+ border-color: #707271;
 53+ background: #bfbfbf url(images/button-down.png) repeat-x scroll 50% 100% !important;
 54+}
 55+body button.ui-button.disabled {
 56+ color: #7f7f7f;
 57+ border-color: #cccccc;
 58+ background: #f2f2f2 url(images/button-disabled.png) repeat-x scroll 50% 100% !important;
 59+}
 60+/* Disables the annoying dashed border Firefox puts on active buttons */
 61+body button.ui-button::-moz-focus-inner {
 62+ border: 0;
 63+}
3364
34 -
35 -
36 -

Follow-up revisions

RevisionCommit summaryAuthorDate
r780961.17: Merge recent fixes tagged on CodeReview, except for problematic revisio...catrope21:17, 8 December 2010

Status & tagging log