r78086 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78085‎ | r78086 | r78087 >
Date:19:16, 8 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Revert unintended whitespace changes from r77922
Modified paths:
  • /trunk/phase3/skins/common/mwsuggest.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/mwsuggest.js
@@ -686,36 +686,28 @@
687687 };
688688
689689 /** Create the container div that will hold the suggested titles */
690 -window.os_createContainer = function(r) {
691 - var c = document.createElement('div');
692 - var s = document.getElementById(r.searchbox);
693 - var pos = os_getElementPosition(r.searchbox);
 690+window.os_createContainer = function( r ) {
 691+ var c = document.createElement( 'div' );
 692+ var s = document.getElementById( r.searchbox );
 693+ var pos = os_getElementPosition( r.searchbox );
694694 var left = pos.left;
695695 var top = pos.top + s.offsetHeight;
696696 c.className = 'os-suggest';
697 - c.setAttribute('id', r.container);
698 - document.body.appendChild(c);
 697+ c.setAttribute( 'id', r.container );
 698+ document.body.appendChild( c );
699699
700700 // dynamically generated style params
701701 // IE workaround, cannot explicitely set "style" attribute
702 - c = document.getElementById(r.container);
 702+ c = document.getElementById( r.container );
703703 c.style.top = top + 'px';
704704 c.style.left = left + 'px';
705705 c.style.width = s.offsetWidth + 'px';
706706
707707 // mouse event handlers
708 - c.onmouseover = function(event) {
709 - os_eventMouseover(r.searchbox, event);
710 - };
711 - c.onmousemove = function(event) {
712 - os_eventMousemove(r.searchbox, event);
713 - };
714 - c.onmousedown = function(event) {
715 - return os_eventMousedown(r.searchbox, event);
716 - };
717 - c.onmouseup = function(event) {
718 - os_eventMouseup(r.searchbox, event);
719 - };
 708+ c.onmouseover = function( event ) { os_eventMouseover( r.searchbox, event ); };
 709+ c.onmousemove = function( event ) { os_eventMousemove( r.searchbox, event ); };
 710+ c.onmousedown = function( event ) { return os_eventMousedown( r.searchbox, event ); };
 711+ c.onmouseup = function( event ) { os_eventMouseup( r.searchbox, event ); };
720712 return c;
721713 };
722714

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77922(bug 26265) Many semicolons are missing from JavaScript files...reedy22:29, 6 December 2010

Status & tagging log