r78081 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78080‎ | r78081 | r78082 >
Date:17:53, 8 December 2010
Author:ialex
Status:ok
Tags:
Comment:
addInlineScript() won't work since the content of $mScripts is added to $scripts before that call
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2443,7 +2443,7 @@
24442444 $action = $wgRequest->getVal( 'action', 'view' );
24452445 if( $this->mTitle && $this->mTitle->isJsSubpage() && $sk->userCanPreview( $action ) ) {
24462446 # XXX: additional security check/prompt?
2447 - $this->addInlineScript( $wgRequest->getText( 'wpTextbox1' ) );
 2447+ $scripts .= Html::inlineScript( "\n" . $wgRequest->getText( 'wpTextbox1' ) . "\n" ) . "\n";
24482448 } else {
24492449 $scripts .= $this->makeResourceLoaderLink(
24502450 $sk, array( 'user', 'user.options' ), 'scripts'

Follow-up revisions

RevisionCommit summaryAuthorDate
r780961.17: Merge recent fixes tagged on CodeReview, except for problematic revisio...catrope21:17, 8 December 2010

Status & tagging log