r78075 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78074‎ | r78075 | r78076 >
Date:17:05, 8 December 2010
Author:tparscal
Status:deferred
Tags:
Comment:
No more tabs - just simple links
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form-hover.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form-icon.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report-hover.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report-icon.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/segment-empty.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/segment-full.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-base.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-break.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-edge.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-fade.png (deleted) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-fade.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-edge.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-base.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-break.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report-hover.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/segment-empty.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/segment-empty.png
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/segment-full.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/segment-full.png
___________________________________________________________________
Added: svn:mime-type
33 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form.png
___________________________________________________________________
Added: svn:mime-type
44 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/report.png
___________________________________________________________________
Added: svn:mime-type
55 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/form-hover.png
___________________________________________________________________
Added: svn:mime-type
66 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.css
@@ -12,7 +12,6 @@
1313 height: 15em;
1414 background-color: #f3f3f3;
1515 border: 1px solid #cccccc;
16 - border-left: none;
1716 padding-bottom: 1px;
1817 }
1918
@@ -32,78 +31,53 @@
3332 padding: 0.75em 1em;
3433 }
3534
36 -.articleFeedback-panel, .articleFeedback-tabs {
 35+.articleFeedback-panel {
3736 float: left;
3837 }
3938
40 -.articleFeedback-tabs {
41 - width: 8em;
42 - height: 15em;
43 - /* @embed */
44 - background-image: url(images/tab-break.png);
45 - background-position: right top;
46 - background-repeat: repeat-y;
47 - padding-bottom: 3px;
 39+.articleFeedback-panel .articleFeedback-buffer {
 40+ padding: 0.75em 1em;
 41+ width: 28em;
4842 }
4943
50 -.articleFeedback-tab {
51 - display: block;
52 - text-align: center;
53 - width: 8em;
54 - height: 7.5em;
55 - cursor: pointer;
56 - background-color: #ffffff;
57 - /* @embed */
58 - background-image: url(images/tab-edge.png);
59 - background-position: right top;
60 - background-repeat: repeat-y;
 44+.articleFeedback-title {
 45+ font-size: 1.4em;
6146 }
6247
63 -.articleFeedback-tabs .articleFeedback-tab-current {
64 - /* @embed */
65 - background-image: url(images/tab-fade.png);
 48+.articleFeedback-switch {
 49+ cursor: pointer;
 50+ color: #0645AD;
 51+ float: right;
 52+ line-height: 1.4em;
 53+ background-repeat: no-repeat;
 54+ background-position: right center;
 55+ padding-right: 22px;
6656 }
6757
68 -.articleFeedback-tab-form {
69 - margin-top: 1px;
70 - margin-bottom: 1px;
 58+.articleFeedback-switch:hover {
 59+ text-decoration: underline;
7160 }
7261
73 -.articleFeedback-tab .articleFeedback-buffer {
74 - display: block;
75 - background-position: 50% 45%;
76 - background-repeat: no-repeat;
77 - padding-top: 6.25em;
78 - padding-left: 1em;
79 - padding-right: 1em;
80 - font-size: 0.8em;
81 - line-height: 1.25em;
82 - color: #0645ad;
 62+.articleFeedback-switch-form {
 63+ /* @embed */
 64+ background-image: url(images/form.png);
8365 }
8466
85 -.articleFeedback-tab-form .articleFeedback-buffer {
 67+.articleFeedback-switch-report {
8668 /* @embed */
87 - background-image: url(images/form-icon.png);
 69+ background-image: url(images/report.png);
8870 }
8971
90 -.articleFeedback-tab-report .articleFeedback-buffer {
 72+.articleFeedback-switch-form:hover {
9173 /* @embed */
92 - background-image: url(images/report-icon.png);
 74+ background-image: url(images/form-hover.png);
9375 }
9476
95 -.articleFeedback-tab:hover .articleFeedback-buffer {
96 - text-decoration: underline;
 77+.articleFeedback-switch-report:hover {
 78+ /* @embed */
 79+ background-image: url(images/report-hover.png);
9780 }
9881
99 -.articleFeedback-panel .articleFeedback-buffer {
100 - padding: 0.75em 1em;
101 - width: 28em;
102 -}
103 -
104 -.articleFeedback-title {
105 - font-size: 1.4em;
106 -}
107 -
10882 .articleFeedback-instructions, .articleFeedback-description {
10983 float: left;
11084 font-weight: bold;
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.js
@@ -25,48 +25,42 @@
2626 },
2727 'build': function( context ) {
2828 context.$ui
29 - .addClass( 'articleFeedback articleFeedback-form' )
 29+ .addClass( 'articleFeedback articleFeedback-visibleWith-form' )
3030 // Append HTML
3131 .append( '\
32 -<div class="articleFeedback-tabs">\
33 - <div class="articleFeedback-tab articleFeedback-tab-form articleFeedback-tab-current" rel="form">\
34 - <div class="articleFeedback-buffer"><msg key="form-tab-label" /></div>\
35 - </div>\
36 - <div class="articleFeedback-tab articleFeedback-tab-report " rel="report">\
37 - <div class="articleFeedback-buffer"><msg key="report-tab-label" /></div>\
38 - </div>\
39 -</div>\
4032 <div class="articleFeedback-panel">\
4133 <div class="articleFeedback-buffer">\
42 - <div class="articleFeedback-title articleFeedback-form"><msg key="form-panel-title" /></div>\
43 - <div class="articleFeedback-title articleFeedback-report"><msg key="report-panel-title" /></div>\
44 - <div class="articleFeedback-instructions articleFeedback-form"><msg key="form-panel-instructions" /></div>\
45 - <div class="articleFeedback-description articleFeedback-report"><msg key="report-panel-description" /></div>\
 34+ <div class="articleFeedback-switch articleFeedback-switch-report articleFeedback-visibleWith-form" rel="report"><msg key="report-switch-label" /></div>\
 35+ <div class="articleFeedback-switch articleFeedback-switch-form articleFeedback-visibleWith-report" rel="form"><msg key="form-switch-label" /></div>\
 36+ <div class="articleFeedback-title articleFeedback-visibleWith-form"><msg key="form-panel-title" /></div>\
 37+ <div class="articleFeedback-title articleFeedback-visibleWith-report"><msg key="report-panel-title" /></div>\
 38+ <div class="articleFeedback-instructions articleFeedback-visibleWith-form"><msg key="form-panel-instructions" /></div>\
 39+ <div class="articleFeedback-description articleFeedback-visibleWith-report"><msg key="report-panel-description" /></div>\
4640 <div style="clear:both;"></div>\
4741 <div class="articleFeedback-ratings">\
4842 <div class="articleFeedback-rating articleFeedback-rating-new" rel="wellsourced">\
4943 <span class="articleFeedback-label" title-msg="field-wellsourced-tip"><msg key="field-wellsourced-label" /></span>\
50 - <div class="articleFeedback-rating-fields articleFeedback-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
51 - <div class="articleFeedback-rating-labels articleFeedback-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
 44+ <div class="articleFeedback-rating-fields articleFeedback-visibleWith-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
 45+ <div class="articleFeedback-rating-labels articleFeedback-visibleWith-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
5246 </div>\
5347 <div class="articleFeedback-rating articleFeedback-rating-new" rel="neutral">\
5448 <span class="articleFeedback-label" title-msg="field-neutral-tip"><msg key="field-neutral-label" /></span>\
55 - <div class="articleFeedback-rating-fields articleFeedback-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
56 - <div class="articleFeedback-rating-labels articleFeedback-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
 49+ <div class="articleFeedback-rating-fields articleFeedback-visibleWith-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
 50+ <div class="articleFeedback-rating-labels articleFeedback-visibleWith-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
5751 </div>\
5852 <div class="articleFeedback-rating articleFeedback-rating-new" rel="complete">\
5953 <span class="articleFeedback-label" title-msg="field-complete-tip"><msg key="field-complete-label" /></span>\
60 - <div class="articleFeedback-rating-fields articleFeedback-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
61 - <div class="articleFeedback-rating-labels articleFeedback-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
 54+ <div class="articleFeedback-rating-fields articleFeedback-visibleWith-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
 55+ <div class="articleFeedback-rating-labels articleFeedback-visibleWith-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
6256 </div>\
6357 <div class="articleFeedback-rating articleFeedback-rating-new" rel="readable">\
6458 <span class="articleFeedback-label" title-msg="field-readable-tip"><msg key="field-readable-label" /></span>\
65 - <div class="articleFeedback-rating-fields articleFeedback-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
66 - <div class="articleFeedback-rating-labels articleFeedback-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
 59+ <div class="articleFeedback-rating-fields articleFeedback-visibleWith-form"><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /><input type="radio" /></div>\
 60+ <div class="articleFeedback-rating-labels articleFeedback-visibleWith-form"><label></label><label></label><label></label><label></label><label></label><div class="articleFeedback-rating-clear"></div></div>\
6761 </div>\
6862 <div style="clear:both;"></div>\
6963 </div>\
70 - <button class="articleFeedback-submit articleFeedback-form" type="submit">Submit feedback</button>\
 64+ <button class="articleFeedback-submit articleFeedback-visibleWith-form" type="submit">Submit feedback</button>\
7165 <div style="clear:both;"></div>\
7266 </div>\
7367 </div>\
@@ -97,7 +91,7 @@
9892 } )
9993 .end()
10094 // Hide report elements initially
101 - .find( '.articleFeedback-report' )
 95+ .find( '.articleFeedback-visibleWith-report' )
10296 .hide()
10397 .end()
10498 // Connect labels and fields
@@ -126,20 +120,18 @@
127121 } );
128122 } )
129123 .end()
130 - // Setup tab behavior
131 - .find( '.articleFeedback-tab' )
 124+ // Setup switch behavior
 125+ .find( '.articleFeedback-switch' )
132126 .click( function( e ) {
133 - $(this).addClass( 'articleFeedback-tab-current' );
134127 context.$ui
135 - .find( '.articleFeedback-' + $(this).attr( 'rel' ) )
 128+ .find( '.articleFeedback-visibleWith-' + $(this).attr( 'rel' ) )
136129 .show()
137130 .end()
138 - .find( '.articleFeedback-tab' )
 131+ .find( '.articleFeedback-switch' )
139132 .not( $(this) )
140133 .each( function() {
141 - $(this).removeClass( 'articleFeedback-tab-current' );
142134 context.$ui
143 - .find( '.articleFeedback-' + $(this).attr( 'rel' ) )
 135+ .find( '.articleFeedback-visibleWith-' + $(this).attr( 'rel' ) )
144136 .hide();
145137 } );
146138 e.preventDefault();

Status & tagging log