r78019 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78018‎ | r78019 | r78020 >
Date:21:53, 7 December 2010
Author:mah
Status:ok
Tags:
Comment:
Filenames with quotes fail here.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/api/RandomImageGenerator.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/api/RandomImageGenerator.php
@@ -200,7 +200,7 @@
201201 $drawCommand = "fill $fill circle $originX,$originY $perimeterX,$perimeterY";
202202 $args[] = '-draw ' . wfEscapeShellArg( $drawCommand );
203203 }
204 - $args[] = $filename;
 204+ $args[] = wfEscapeShellArg( $filename );
205205
206206 $command = wfEscapeShellArg( $wgImageMagickConvertCommand ) . " " . implode( " ", $args );
207207 $retval = null;

Status & tagging log