r77990 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77989‎ | r77990 | r77991 >
Date:16:33, 7 December 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
isValid() was calling methods on non-objects
Modified paths:
  • /trunk/extensions/Translate/utils/MessageGroupCache.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageGroupCache.php
@@ -141,7 +141,7 @@
142142 $newhash = md5( file_get_contents( $filename ) );
143143 if ( $this->get( '#filehash' ) === $newhash ) {
144144 // Update cache so that we don't need to compare hashes next time
145 - $cache->create( $created );
 145+ $this->create( $created );
146146 return true;
147147 }
148148
@@ -155,7 +155,7 @@
156156 // Content hash check
157157 if ( $this->get( '#msghash' ) === md5( serialize( ksort( $messages ) ) ) ) {
158158 // Update cache so that we don't need to do slow checks next time
159 - $cache->create( $created );
 159+ $this->create( $created );
160160 return true;
161161 }
162162

Status & tagging log