r77987 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77986‎ | r77987 | r77988 >
Date:16:23, 7 December 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Shutup more warnings
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -365,7 +365,6 @@
366366 $response = FormatJson::decode( $json );
367367
368368 if ( $json === false ) {
369 - error_log( __METHOD__ . ': Http::get failed' );
370369 // Most likely a timeout or other general error
371370 self::reportTranslationServiceFailure( $serviceName );
372371
@@ -466,7 +465,9 @@
467466 return null;
468467 }
469468
470 - error_log( __METHOD__ . ': Http::get failed:' . $error );
 469+ if ( $error ) {
 470+ error_log( __METHOD__ . ': Http::get failed:' . $error );
 471+ }
471472 // Most likely a timeout or other general error
472473 self::reportTranslationServiceFailure( $serviceName );
473474 return null;

Status & tagging log