r77962 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77961‎ | r77962 | r77963 >
Date:08:04, 7 December 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r77961 - apperently modified code in the wrong extension >_>
Modified paths:
  • /trunk/extensions/Push/Push.hooks.php (modified) (history)
  • /trunk/extensions/Push/Push.i18n.php (modified) (history)
  • /trunk/extensions/Push/specials/Push_Body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Push/Push.i18n.php
@@ -31,5 +31,5 @@
3232 'push-import-revision-comment' => ' Last comment: $1',
3333
3434 // Special page
35 - 'special-push' => 'Push',
 35+ 'special-push' => 'Push pages',
3636 );
\ No newline at end of file
Index: trunk/extensions/Push/specials/Push_Body.php
@@ -5,7 +5,10 @@
66 *
77 * @since 0.1
88 *
9 - * @author Jeroen De Dauw
 9+ * @file Push_Body.php
 10+ * @ingroup Push
 11+ *
 12+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1013 */
1114 class SpecialPush extends SpecialPage {
1215
Index: trunk/extensions/Push/Push.hooks.php
@@ -20,15 +20,10 @@
2121 * @return true
2222 */
2323 public static function addToAdminLinks( &$admin_links_tree ) {
24 - $displaying_data_section = $admin_links_tree->getSection( wfMsg( 'smw_adminlinks_displayingdata' ) );
25 -
26 - // Escape if SMW hasn't added links.
27 - if ( is_null( $displaying_data_section ) ) return true;
28 - $smw_docu_row = $displaying_data_section->getRow( 'smw' );
29 -
30 - $maps_docu_label = wfMsg( 'adminlinks_documentation', wfMsg( 'maps_name' ) );
31 - $smw_docu_row->addItem( AlItem::newFromExternalLink( 'http://mapping.referata.com/wiki/Maps', $maps_docu_label ) );
32 -
 24+ $ioSection = $admin_links_tree->getSection( wfMsg( 'adminlinks_importexport' ) );
 25+ $mainRow = $ioSection->getRow( 'main' );
 26+ $mainRow->addItem( ALItem::newFromSpecialPage( 'Push' ) );
 27+
3328 return true;
3429 }
3530

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77961Added AdminLinks hook, removed not needed code and added special page stubjeroendedauw07:52, 7 December 2010

Status & tagging log