r77953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77952‎ | r77953 | r77954 >
Date:02:42, 7 December 2010
Author:demon
Status:ok
Tags:
Comment:
Fix breakage from r75542: FakeMaintenance needs to set at least $mSelf so when runChild() calls loadParamsAndArgs() it doesn't pass nothing and thus try to fall back on $argv. This breaks the web updater, where that is undefined.
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -1130,6 +1130,7 @@
11311131 }
11321132
11331133 class FakeMaintenance extends Maintenance {
 1134+ protected $mSelf = "FakeMaintenanceScript";
11341135 public function execute() {
11351136 return;
11361137 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75542Make update.php obey --quietplatonides14:38, 27 October 2010

Status & tagging log