r77951 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77950‎ | r77951 | r77952 >
Date:02:20, 7 December 2010
Author:demon
Status:ok
Tags:
Comment:
Address fixme on r67621: use $wgDefaultSkin instead of hardcoding vector
Would like a UI to choose skin with like previews or something, but its not urgent
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -45,7 +45,7 @@
4646 'wgDBtype', 'wgSecretKey', 'wgRightsUrl', 'wgSitename', 'wgRightsIcon',
4747 'wgRightsText', 'wgRightsCode', 'wgMainCacheType', 'wgEnableUploads',
4848 'wgMainCacheType', '_MemCachedServers', 'wgDBserver', 'wgDBuser',
49 - 'wgDBpassword', 'wgUseInstantCommons', 'wgUpgradeKey'
 49+ 'wgDBpassword', 'wgUseInstantCommons', 'wgUpgradeKey', 'wgDefaultSkin',
5050 ),
5151 $db->getGlobalNames()
5252 );
@@ -286,7 +286,7 @@
287287
288288 ## Default skin: you can change the default skin. Use the internal symbolic
289289 ## names, ie 'standard', 'nostalgia', 'cologneblue', 'monobook', 'vector':
290 -\$wgDefaultSkin = 'vector';
 290+\$wgDefaultSkin = \"{$this->values['wgDefaultSkin']}\";
291291
292292 ## For attaching licensing metadata to pages, and displaying an
293293 ## appropriate copyright notice / icon. GNU Free Documentation
Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -49,6 +49,7 @@
5050 'wgSecretKey',
5151 'wgUseInstantCommons',
5252 'wgUpgradeKey',
 53+ 'wgDefaultSkin',
5354 );
5455
5556 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67621Followup r66383, need to update generated LocalSettings as welldemon13:38, 8 June 2010

Status & tagging log