r77945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77944‎ | r77945 | r77946 >
Date:01:27, 7 December 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r77942
Modified paths:
  • /trunk/extensions/Push/includes/Push_Tab.php (modified) (history)
  • /trunk/extensions/Push/includes/ext.push.tab.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Push/includes/Push_Tab.php
@@ -79,7 +79,7 @@
8080
8181 efPushAddJSLocalisation();
8282
83 - // TODO: jquery
 83+ $wgOut->includeJQuery();
8484
8585 $wgOut->addHeadItem(
8686 'ext.push.tab',
Index: trunk/extensions/Push/includes/ext.push.tab.js
@@ -5,9 +5,17 @@
66 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
77 */
88
9 -$( document ).ready( function() {
 9+(function($) { $( document ).ready( function() {
1010
11 - // TODO: message b/c
 11+ // Compatibility with pre-RL code.
 12+ // Messages will have been loaded into wgPushMessages.
 13+ if ( typeof mediaWiki === 'undefined' ) {
 14+ mediaWiki = new Object();
 15+
 16+ mediaWiki.msg = function( message ) {
 17+ return window.wgPushMessages[message];
 18+ }
 19+ }
1220
1321 $('.push-button').click(function() {
1422 this.disabled = true;
@@ -100,4 +108,4 @@
101109 sender.innerHTML = mediaWiki.msg( 'push-button-failed' );
102110 }
103111
104 -} );
 112+} ); })(jQuery);
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77942Adding support for mw 1.16jeroendedauw01:13, 7 December 2010

Status & tagging log