r77901 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77900‎ | r77901 | r77902 >
Date:20:20, 6 December 2010
Author:catrope
Status:ok
Tags:
Comment:
1.16wmf4: MFT r65181, r65209
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/ExtensionDistributor (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/ExtensionDistributor/ExtensionDistributor_body.php
@@ -164,9 +164,13 @@
165165 Xml::element( 'input' , array( 'type' => 'hidden',
166166 'name' => 'extdist_extension', 'value' => $extensionName ) ) .
167167 "<select name=\"extdist_version\">\n" );
 168+
 169+ $selected = 0;
 170+
168171 foreach ( $versions as $branchPath => $branchName ) {
169 - $wgOut->addHTML( Xml::element( 'option',
170 - array( 'value' => $branchPath ), $branchName ) . "\n" );
 172+ $wgOut->addHTML( Xml::option( $branchName, $branchPath, ($selected == 1) ) );
 173+
 174+ $selected++;
171175 }
172176 $wgOut->addHTML(
173177 Xml::closeElement( 'select' ) . ' ' .
Property changes on: branches/wmf/1.16wmf4/extensions/ExtensionDistributor
___________________________________________________________________
Modified: svn:mergeinfo
174178 Merged /trunk/extensions/ExtensionDistributor:r65181,65209

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65181Apply my patch for Bug 19155 - Make the selection box for ExtensionDistributo...reedy20:47, 17 April 2010
r65209Followup for r65181reedy11:04, 18 April 2010

Status & tagging log