r77891 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77890‎ | r77891 | r77892 >
Date:17:07, 6 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Per Hashar, r77819, @private comment. Explicit public method definition
Modified paths:
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -102,7 +102,7 @@
103103 *
104104 * @return string HTML output
105105 */
106 - function getHTML() {
 106+ public function getHTML() {
107107 global $wgOut, $wgCategoryMagicGallery, $wgContLang;
108108 wfProfileIn( __METHOD__ );
109109
@@ -417,6 +417,7 @@
418418 * @param $articles_start_char Array
419419 * @param $cutoff Int
420420 * @return String
 421+ * @private
421422 */
422423 function formatList( $articles, $articles_start_char, $cutoff = 6 ) {
423424 if ( count ( $articles ) > $cutoff ) {
@@ -441,6 +442,7 @@
442443 * @param $articles Array
443444 * @param $articles_start_char Array
444445 * @return String
 446+ * @private
445447 */
446448 static function columnList( $articles, $articles_start_char ) {
447449 $columns = array_combine( $articles, $articles_start_char );
@@ -492,6 +494,7 @@
493495 * @param $articles Array
494496 * @param $articles_start_char Array
495497 * @return String
 498+ * @private
496499 */
497500 static function shortList( $articles, $articles_start_char ) {
498501 $r = '<h3>' . htmlspecialchars( $articles_start_char[0] ) . "</h3>\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77819-rakkaus/#mediawiki-i18n- [05-Dec-2010 18:22:39] PHP Fatal error: Call to pr...reedy18:27, 5 December 2010

Status & tagging log