r77886 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77885‎ | r77886 | r77887 >
Date:16:08, 6 December 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Added fixes for tipsy font size - because tips are rendering outside of the body their text size is not affected by rules for bodyContent where the text is usually adjusted up or down a final time.
Modified paths:
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -1270,3 +1270,8 @@
12711271 .no-text-transform {
12721272 text-transform: none;
12731273 }
 1274+
 1275+/* Tooltips are outside of the normal body code, so this helps make the size of the text sensible */
 1276+.tipsy {
 1277+ font-size: 127%;
 1278+}
\ No newline at end of file
Index: trunk/phase3/skins/modern/main.css
@@ -875,3 +875,8 @@
876876 margin: 0pt;
877877 padding: 0pt;
878878 }
 879+
 880+/* Tooltips are outside of the normal body code, so this helps make the size of the text sensible */
 881+.tipsy {
 882+ font-size: 130%;
 883+}
\ No newline at end of file
Index: trunk/phase3/skins/vector/screen.css
@@ -1185,3 +1185,8 @@
11861186 p.mw-filedelete-editreasons, p.mw-delete-editreasons {
11871187 float: right;
11881188 }
 1189+
 1190+/* Tooltips are outside of the normal body code, so this helps make the size of the text sensible */
 1191+.tipsy {
 1192+ font-size: 0.8em;
 1193+}
\ No newline at end of file

Comments

#Comment by RobLa-WMF (talk | contribs)   23:39, 5 January 2011

Trevor, could you pester Brandon for a review on this one?

#Comment by Catrope (talk | contribs)   12:26, 6 January 2011

Removing from my review list. The changes are trivial, they just need Brandon to decide whether they're The Right Thing To Do or not.

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:29, 6 January 2011

Ryan Kaldari can review this patch to confirm it does what it claims, there is no change in the UI here, just a patch to ensure tipsy functions similarly on all skins.

#Comment by Kaldari (talk | contribs)   01:28, 14 January 2011

Looks good.

Status & tagging log