r77855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77854‎ | r77855 | r77856 >
Date:04:33, 6 December 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
remove dead code
Modified paths:
  • /trunk/extensions/DSMW/specials/ArticleAdminPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DSMW/specials/ArticleAdminPage.php
@@ -195,8 +195,6 @@
196196 </table>
197197 </FORM>';
198198
199 -
200 -
201199 ///////////// PUSHFEEDS TABLE//////////////////////////
202200
203201 $i = 0;
@@ -320,15 +318,6 @@
321319 </div>
322320 ';
323321
324 -// if (!$this->getArticle('Property:ChangeSetID')->exists()) {
325 -// $output .='
326 -// <FORM METHOD="POST" ACTION="'.$urlServer.'/extensions/DSMW/bot/DSMWBot.php" name="scriptExec">
327 -// <table'.$tableStyle.'><td><button type="submit"><b>[UPDATE PROPERTY TYPE]</b></button>
328 -// </td></table>
329 -// <input type="hidden" name="server" value="'.$urlServer.'">
330 -// </form>';
331 -// }
332 -
333322 $wgOut->addHTML( $output );
334323 return false;
335324 }
@@ -481,24 +470,15 @@
482471 }
483472
484473 /**
485 - * @param <String> $title
486 - * @return <String>
 474+ * Returns an array of page titles received via the request.
 475+ *
 476+ * @return array
487477 */
488 - function getPageIdWithTitle( $title ) {
489 - $dbr = wfGetDB( DB_SLAVE );
490 - $id = $dbr->selectField( 'page', 'page_id', array(
491 - 'page_title' => $title ) );
492 - return $id;
493 - }
494 -
495 - /**
496 - * returns an array of page titles received via the request
497 - */
498 - function getRequestedPages( $request ) {
499 -
 478+ protected function getRequestedPages( $request ) {
500479 $results = array();
501480 $res = utils::getSemanticQuery( $request );
502481 $count = $res->getCount();
 482+
503483 for ( $i = 0; $i < $count; $i++ ) {
504484
505485 $row = $res->getNext();
@@ -515,14 +495,4 @@
516496 return $results;
517497 }
518498
519 - function getArticle( $article_title ) {
520 - $title = Title::newFromText( $article_title );
521 -
522 - // Can't load page if title is invalid.
523 - if ( $title == null ) return null;
524 - $article = new Article( $title );
525 -
526 - return $article;
527 - }
528 -
529499 }

Status & tagging log