r77798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77797‎ | r77798 | r77799 >
Date:13:38, 5 December 2010
Author:catrope
Status:ok
Tags:
Comment:
(bug 26228) On certain PHP 5.2 installs, finfo functions can be available while FILEINFO_MIME_TYPE is not. Check for the latter explicitly
Modified paths:
  • /trunk/phase3/includes/libs/CSSMin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/CSSMin.php
@@ -111,7 +111,8 @@
112112 // Try a couple of different ways to get the mime-type of a file,
113113 // in order of preference
114114 if ( $realpath
115 - && function_exists( 'finfo_file' ) && function_exists( 'finfo_open' ) )
 115+ && function_exists( 'finfo_file' ) && function_exists( 'finfo_open' )
 116+ && defined( 'FILEINFO_MIME_TYPE' ) )
116117 {
117118 // As of PHP 5.3, this is how you get the mime-type of a file;
118119 // it uses the Fileinfo PECL extension

Status & tagging log